fix(4687): rest status codes #4706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: p1729 <pankajkumar1729@gmail.com>
Signed-off-by: p1729 <pankajkumar1729@gmail.com>
|
@Bukhtawar I have opened this PR to get your early feedback on the expected solution. I will be adding tests as well if needed soon. |
Gradle Check (Jenkins) Run Completed with:
|
dbwiddis
added
the
hacktoberfest
dblock
reviewed
Oct 11, 2022
| @Override | ||
| public RestStatus status() { | ||
| String causeDescription = unwrapCause().getMessage(); | ||
| if (causeDescription != null && causeDescription.contains("not found")) { |
There was a problem hiding this comment.
This isn't very reliable.
Start by writing a unit test that reproduces the problem, then we can talk about how to fix it best.
There was a problem hiding this comment.
make sense, I will try to write an integration/sociable test.
|
@p1729 could you please share status of the progress here for this PR. PLease let us know if you need any help. Thanks |
|
@p1729: Are you still working on this PR ? |
|
@p1729 Closing this PR as it hasn't been worked on in a while. Please let us know if you are still working on it and we'll re-open the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
#4687
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.