Use timeout support of the IndexSearcher instead of custom implementation #4906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
added
feature
reta
force-pushed
the
issue-4487
branch
2 times, most recently
from
582840a to
18da1fc
Compare
Gradle Check (Jenkins) Run Completed with:
|
…tion Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
andrross
reviewed
Nov 9, 2022
| @@ -43,6 +43,8 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Copy `build.sh` over from opensearch-build ([#4887](https://github.com/opensearch-project/OpenSearch/pull/4887)) | |||
| - Add project health badges to the README.md ([#4843](https://github.com/opensearch-project/OpenSearch/pull/4843)) | |||
| - Added changes for graceful node decommission ([#4586](https://github.com/opensearch-project/OpenSearch/pull/4586)) | |||
| - Use timeout support of the IndexSearcher instead of custom implementation([#4906](https://github.com/opensearch-project/OpenSearch/pull/4906)) | |||
There was a problem hiding this comment.
Probably a "skip-changelog" case now since this is a refactoring and not a functional change, right?
There was a problem hiding this comment.
Thanks @andrross , have a loooong discussion with Apache Lucene team, will postpone this future a bit (for 2 reasons 1) there are a number of improvements in work 2) the way we use IndexSearcher does not allow us to use this feature as-is, without copying code
|
This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
In Apache Lucene 9.3, the
IndexSearcherhas been enhanced to support timeouts. The OpenSearch uses custom implementation (based on cancellable runnable and timeout checker) in order to cancel search queries by timeout. For more context, check https://issues.apache.org/jira/browse/LUCENE-10151 please.Issues Resolved
Closes #4487
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.