[Remove] LegacyESVersion.V_7_10_* constants #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all usages of LegacyESVersion.V_7_10_ version constants along with ancient API logic. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
added
non-issue
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
reta
reviewed
Nov 1, 2022
| @@ -326,11 +325,7 @@ public DiscoveryNode(StreamInput in) throws IOException { | |||
| final String roleName = in.readString(); | |||
| final String roleNameAbbreviation = in.readString(); | |||
| final boolean canContainData; | |||
There was a problem hiding this comment.
Minor, final boolean canContainData = in.readBoolean();
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
reta
approved these changes
Nov 1, 2022
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all usages of LegacyESVersion.V_7_10_ version constants along with ancient API logic.
closes #2747