-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run backport workflow it a backport label was added. #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@VachaShah I think we might need this in a bunch of projects as we also are rolling out changelog labelling. |
dblock
force-pushed
the
backport-on-labels
branch
from
November 8, 2022 15:06
e923703
to
2b0743c
Compare
andrross
approved these changes
Nov 8, 2022
Gradle Check (Jenkins) Run Completed with:
|
dblock
force-pushed
the
backport-on-labels
branch
from
November 8, 2022 15:11
2b0743c
to
c51f0c3
Compare
dblock
added
backport 1.x
backport 2.x
Backport to 2.x branch
and removed
backport 1.x
backport 2.x
Backport to 2.x branch
labels
Nov 8, 2022
Signed-off-by: dblock <dblock@dblock.org>
dblock
force-pushed
the
backport-on-labels
branch
from
November 8, 2022 15:21
c51f0c3
to
2494cc0
Compare
Doesn't seem to work :( Found https://stackoverflow.com/questions/71523153/github-actions-on-pull-request-merged-with-speciphic-labels for the same. This skips non-backport labels correctly, so it's some progress.
But this still runs on non-merged PRs, not sure why.
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
Nov 8, 2022
Gradle Check (Jenkins) Run Completed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@dblock.org
Description
In #5143 the backport workflow ran because I added a
skip-changelog
label.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.