Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run backport workflow it a backport label was added. #5144

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 8, 2022

Signed-off-by: dblock dblock@dblock.org

Description

In #5143 the backport workflow ran because I added a skip-changelog label.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested review from a team and reta as code owners November 8, 2022 15:05
@dblock
Copy link
Member Author

dblock commented Nov 8, 2022

@VachaShah I think we might need this in a bunch of projects as we also are rolling out changelog labelling.

@dblock dblock force-pushed the backport-on-labels branch from e923703 to 2b0743c Compare November 8, 2022 15:06
@dblock dblock added backport 1.x backport 2.x Backport to 2.x branch labels Nov 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@dblock dblock force-pushed the backport-on-labels branch from 2b0743c to c51f0c3 Compare November 8, 2022 15:11
@dblock dblock added backport 1.x backport 2.x Backport to 2.x branch and removed backport 1.x backport 2.x Backport to 2.x branch labels Nov 8, 2022
Signed-off-by: dblock <dblock@dblock.org>
@dblock dblock force-pushed the backport-on-labels branch from c51f0c3 to 2494cc0 Compare November 8, 2022 15:21
@dblock
Copy link
Member Author

dblock commented Nov 8, 2022

Doesn't seem to work :( Found https://stackoverflow.com/questions/71523153/github-actions-on-pull-request-merged-with-speciphic-labels for the same.

This skips non-backport labels correctly, so it's some progress.

if: ${{ contains(github.event.label.name, 'backport ') 

But this still runs on non-merged PRs, not sure why.

if: ${{ contains(github.event.label.name, 'backport ') && (github.event.pull_request.merged == true) }}

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member Author

dblock commented Nov 8, 2022

Tests with failures:
 - org.opensearch.clustermanager.ClusterManagerTaskThrottlingIT.testTimeoutWhileThrottling
 - org.opensearch.persistent.PersistentTasksExecutorFullRestartIT.testFullClusterRestart

#5083
#5145

@dblock dblock merged commit 5f05618 into opensearch-project:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants