[BUG] Gradle Check Failed on Windows due to JDK19 pulling by gradle #5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
commented
Nov 9, 2022
build.gradle
Outdated
| @@ -398,6 +399,10 @@ gradle.projectsEvaluated { | |||
| allprojects { | |||
| project.tasks.withType(JavaForkOptions) { | |||
| maxHeapSize project.property('options.forkOptions.memoryMaximumSize') | |||
| // Temporary workaround to ublock the builds (see https://github.com/gradle/gradle/issues/22659) | |||
| if (OperatingSystem.current().isWindows()) { | |||
| executable null | |||
There was a problem hiding this comment.
@dblock I have not yet figured out what the cause is (why the incorrect executable is being wired in) and working on that, @peterzhuamazon if you need to unblock Windows builds, please go ahead (if it could wait for a proper fix in place, even better).
dblock
approved these changes
Nov 9, 2022
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5188 +/- ##
============================================
- Coverage 71.05% 70.93% -0.13%
+ Complexity 58248 58154 -94
============================================
Files 4708 4708
Lines 277559 277559
Branches 40189 40189
============================================
- Hits 197229 196878 -351
- Misses 64246 64569 +323
- Partials 16084 16112 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
reta
force-pushed
the
issue-5181
branch
2 times, most recently
from
57efc04
to
5cd46f6
Compare
|
@dblock @peterzhuamazon we are good to go with permanent fix, thanks guys |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
peterzhuamazon
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Thanks @reta for this and I also learned a bit about these plugins.
❤️
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
reta
added
backport 2.x
dblock
pushed a commit
that referenced
this pull request
Nov 10, 2022
…5188) (#5192) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 650039c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Nov 10, 2022
…5188) (#5191) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 650039c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
The internal plugin incorrectly assumes binaries for Windows (the issue was always present but only recently started to manifest itself because if gradle/gradle@75eb1b7
Issues Resolved
Closes #5181
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.