-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AwarenessAttributeDecommissionIT flaky tests #5252
Fix AwarenessAttributeDecommissionIT flaky tests #5252
Conversation
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5252 +/- ##
============================================
- Coverage 70.97% 70.90% -0.07%
+ Complexity 58186 58126 -60
============================================
Files 4708 4708
Lines 277558 277558
Branches 40190 40190
============================================
- Hits 197006 196813 -193
- Misses 64444 64621 +177
- Partials 16108 16124 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, merge?
Yes, we can merge this now. I'll push another empty commit to verify it passes again and not flaky anymore |
Looks like some transient connectivity failures ... let's keep retrying for now. @imRishN instead of empty commits you can |
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
56e7c65
to
86af94c
Compare
Gradle Check (Jenkins) Run Completed with:
|
@dblock Thanks for merging it. Can you please also help me add 2.x backport tag so that this commit doesn't get missed in future releases? Thanks! |
* Pick non decommissioned node for client requests Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Fix spotless check Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Fix Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Empty-Commit Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Empty-Commit Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Empty-Commit Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Empty-Commit Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Fix Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Empty-Commit Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Empty-Commit Signed-off-by: Rishab Nahata <rnnahata@amazon.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com> (cherry picked from commit 3c02b43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Pick non decommissioned node for client requests Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Fix spotless check Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Fix Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Empty-Commit Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Empty-Commit Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Empty-Commit Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Empty-Commit Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Fix Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Empty-Commit Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Empty-Commit Signed-off-by: Rishab Nahata <rnnahata@amazon.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com> (cherry picked from commit 3c02b43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Few tests in AwarenessAttributeDecommissionIT fails transiently as while making the client request if a
viaNode
is not specified it uses aRandomizingClient
which can let the request land up on a decommissioned node and then we see exception that cluster manager is not discovered which is not the case. This PR aims to always pick a active node to route the request.Issues Resolved
#5220
#5221
#5189
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.