Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AwarenessAttributeDecommissionIT flaky tests #5252

Merged
merged 10 commits into from
Nov 15, 2022

Conversation

imRishN
Copy link
Member

@imRishN imRishN commented Nov 15, 2022

Description

Few tests in AwarenessAttributeDecommissionIT fails transiently as while making the client request if a viaNode is not specified it uses a RandomizingClient which can let the request land up on a decommissioned node and then we see exception that cluster manager is not discovered which is not the case. This PR aims to always pick a active node to route the request.

Issues Resolved

#5220
#5221
#5189

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN imRishN changed the title Decommission/integ test fix Fix AwarenessAttributeDecommissionIT flaky tests Nov 15, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Merging #5252 (56e7c65) into main (831b3a0) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5252      +/-   ##
============================================
- Coverage     70.97%   70.90%   -0.07%     
+ Complexity    58186    58126      -60     
============================================
  Files          4708     4708              
  Lines        277558   277558              
  Branches      40190    40190              
============================================
- Hits         197006   196813     -193     
- Misses        64444    64621     +177     
- Partials      16108    16124      +16     
Impacted Files Coverage Δ
...search/indices/recovery/RecoveryTargetHandler.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/opensearch/client/cluster/ProxyModeInfo.java 0.00% <0.00%> (-55.00%) ⬇️
...ch/transport/ReceiveTimeoutTransportException.java 50.00% <0.00%> (-50.00%) ⬇️
...rch/client/transport/NoNodeAvailableException.java 28.57% <0.00%> (-42.86%) ⬇️
...h/action/ingest/SimulateDocumentVerboseResult.java 60.71% <0.00%> (-39.29%) ⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java 56.25% <0.00%> (-37.50%) ⬇️
.../opensearch/client/indices/CloseIndexResponse.java 56.25% <0.00%> (-35.00%) ⬇️
...r/src/main/java/org/opensearch/http/HttpUtils.java 16.66% <0.00%> (-33.34%) ⬇️
...functionscore/ExponentialDecayFunctionBuilder.java 40.00% <0.00%> (-28.00%) ⬇️
...a/org/opensearch/index/mapper/MapperException.java 75.00% <0.00%> (-25.00%) ⬇️
... and 477 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, merge?

@imRishN imRishN marked this pull request as ready for review November 15, 2022 15:47
@imRishN imRishN requested review from a team and reta as code owners November 15, 2022 15:47
@imRishN
Copy link
Member Author

imRishN commented Nov 15, 2022

Makes sense, merge?

Yes, we can merge this now. I'll push another empty commit to verify it passes again and not flaky anymore

@dblock
Copy link
Member

dblock commented Nov 15, 2022

Looks like some transient connectivity failures ... let's keep retrying for now.

@imRishN instead of empty commits you can git commit --amend, then git push origin integ-test-fix -f.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN imRishN force-pushed the decommission/integ-test-fix branch from 56e7c65 to 86af94c Compare November 15, 2022 16:27
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock dblock merged commit 3c02b43 into opensearch-project:main Nov 15, 2022
@imRishN
Copy link
Member Author

imRishN commented Nov 15, 2022

@dblock Thanks for merging it. Can you please also help me add 2.x backport tag so that this commit doesn't get missed in future releases? Thanks!

@dblock dblock added the backport 2.x Backport to 2.x branch label Nov 15, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 15, 2022
* Pick non decommissioned node for client requests

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Fix spotless check

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Fix

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Empty-Commit

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Empty-Commit

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Empty-Commit

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Empty-Commit

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Fix

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Empty-Commit

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Empty-Commit

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
(cherry picked from commit 3c02b43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Nov 15, 2022
* Pick non decommissioned node for client requests

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Fix spotless check

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Fix

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Empty-Commit

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Empty-Commit

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Empty-Commit

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Empty-Commit

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Fix

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Empty-Commit

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Empty-Commit

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
(cherry picked from commit 3c02b43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants