Call 'toArray()' with an empty array instead of a pre-sized array #5277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to `Collection.toArray()` is not consistent and in many places and use a pre-sized array parameter. This change makes a consistent use of the `toArray(new T[0])`. The empty array usage is considered faster, safer and cleaner than the sized based array approach. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
andrross
reviewed
Nov 16, 2022
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
|
Just a comment on the subject, seems like similar changes are making its way into JDK (https://bugs.openjdk.org/browse/JDK-8258804 fe) |
|
Just for the record, it seems like |
reta
approved these changes
Nov 16, 2022
No, I think the issue is just to update it internally in JDK. This is the commit openjdk/jdk@39e03a0b |
kotwanikunal
approved these changes
Nov 16, 2022
I think I misunderstood your comment earlier. Yes, there were a few places they have updated it. |
3 tasks
andrross
pushed a commit
to andrross/OpenSearch
that referenced
this pull request
Nov 5, 2024
…ensearch-project#5277) Calls to `Collection.toArray()` is not consistent and in many places and use a pre-sized array parameter. This change makes a consistent use of the `toArray(new T[0])`. The empty array usage is considered faster, safer and cleaner than the sized based array approach. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
3 tasks
reta
pushed a commit
that referenced
this pull request
Nov 5, 2024
) (#16563) Calls to `Collection.toArray()` is not consistent and in many places and use a pre-sized array parameter. This change makes a consistent use of the `toArray(new T[0])`. The empty array usage is considered faster, safer and cleaner than the sized based array approach. Signed-off-by: Rabi Panda <adnapibar@gmail.com> Co-authored-by: Rabi Panda <adnapibar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calls to
Collection.toArray()is not consistent and in many places and use a pre-sized array parameter. This change refactors the calls to consistently usetoArray(new T[0]). The empty array usage is considered faster, safer and cleaner than the sized based array approach.Ref: https://shipilev.net/blog/2016/arrays-wisdom-ancients/
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Rabi Panda adnapibar@gmail.com