Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix URLDecodeProcessor random test failure #5340

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 152f3f4 from #5328.

The randomly-generated input for this test may contain non-URL-safe
characters (such as `%`) so it needs to be URL encoded as well.

Signed-off-by: Andrew Ross <andrross@amazon.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit 152f3f4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners November 22, 2022 18:06
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.repositories.s3.RepositoryS3ClientYamlTestSuiteIT.test {yaml=repository_s3/20_repository_permanent_credentials/Snapshot and Restore with repository-s3 using permanent credentials}

@codecov-commenter
Copy link

Codecov Report

Merging #5340 (57814d6) into 2.x (d74d992) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #5340      +/-   ##
============================================
+ Coverage     70.67%   70.75%   +0.08%     
- Complexity    58308    58386      +78     
============================================
  Files          4700     4700              
  Lines        279111   279109       -2     
  Branches      40749    40749              
============================================
+ Hits         197254   197479     +225     
+ Misses        65377    65150     -227     
  Partials      16480    16480              
Impacted Files Coverage Δ
...g/opensearch/ingest/common/URLDecodeProcessor.java 87.50% <100.00%> (+17.50%) ⬆️
...pensearch/client/cluster/RemoteConnectionInfo.java 0.00% <0.00%> (-70.00%) ⬇️
...a/org/opensearch/client/cluster/SniffModeInfo.java 0.00% <0.00%> (-62.50%) ⬇️
...ava/org/opensearch/action/NoSuchNodeException.java 0.00% <0.00%> (-50.00%) ⬇️
.../org/opensearch/client/indices/AnalyzeRequest.java 27.00% <0.00%> (-49.00%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-40.75%) ⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java 60.00% <0.00%> (-40.00%) ⬇️
.../opensearch/client/cluster/RemoteInfoResponse.java 61.53% <0.00%> (-38.47%) ⬇️
...luster/routing/allocation/RoutingExplanations.java 62.06% <0.00%> (-37.94%) ⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java 56.25% <0.00%> (-37.50%) ⬇️
... and 477 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrross
Copy link
Member

      1 org.opensearch.repositories.s3.RepositoryS3ClientYamlTestSuiteIT.test {yaml=repository_s3/20_repository_permanent_credentials/Snapshot and Restore with repository-s3 using permanent credentials}

@reta FYI It looks like your fix is included here but this test was still flaky :(

@andrross andrross merged commit 4233454 into 2.x Nov 22, 2022
@github-actions github-actions bot deleted the backport/backport-5328-to-2.x branch November 22, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants