Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Use BuildParams.isCi() instead of checking env var (#5368) #5372

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 24, 2022

Backport of #5368 to 2.x

…t#5368)

Signed-off-by: Andrew Ross <andrross@amazon.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
@reta reta requested a review from andrross November 24, 2022 14:58
@reta reta requested a review from a team as a code owner November 24, 2022 14:58
@reta reta added backport PRs or issues specific to backporting features or enhancments and removed backlog labels Nov 24, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchCancellationIT.testCancellationDuringFetchPhaseUsingRequestParameter

@codecov-commenter
Copy link

Codecov Report

Merging #5372 (2bfe7b2) into 2.x (05979b4) will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #5372      +/-   ##
============================================
+ Coverage     70.67%   70.76%   +0.08%     
- Complexity    58335    58398      +63     
============================================
  Files          4701     4701              
  Lines        279131   279131              
  Branches      40753    40753              
============================================
+ Hits         197271   197519     +248     
+ Misses        65376    65143     -233     
+ Partials      16484    16469      -15     
Impacted Files Coverage Δ
...search/indices/recovery/RecoveryTargetHandler.java 0.00% <0.00%> (-100.00%) ⬇️
...n/indices/forcemerge/ForceMergeRequestBuilder.java 0.00% <0.00%> (-75.00%) ⬇️
.../indices/forcemerge/TransportForceMergeAction.java 25.00% <0.00%> (-75.00%) ⬇️
...regations/metrics/AbstractHyperLogLogPlusPlus.java 51.72% <0.00%> (-44.83%) ⬇️
...cluster/coordination/PublishClusterStateStats.java 33.33% <0.00%> (-37.51%) ⬇️
...nsearch/index/shard/IndexShardClosedException.java 66.66% <0.00%> (-33.34%) ⬇️
...on/admin/indices/forcemerge/ForceMergeRequest.java 52.77% <0.00%> (-33.34%) ⬇️
...rc/main/java/org/opensearch/ingest/IngestInfo.java 51.72% <0.00%> (-27.59%) ⬇️
...opensearch/snapshots/SnapshotRestoreException.java 25.00% <0.00%> (-25.00%) ⬇️
...a/org/opensearch/transport/netty4/Netty4Utils.java 42.42% <0.00%> (-21.22%) ⬇️
... and 471 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dreamer-89
Copy link
Member

Backport (pull_request_target) workflow is failing with below error. I tried to re-run but it fails instantly with same error. The original PR is already merged into main.
@VachaShah : Do you know why is this failing ?

Error: Error: For security reasons, this action should only run on merged PRs.

@andrross andrross merged commit 4b991dd into opensearch-project:2.x Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants