Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix bwc for cluster manager throttling settings #5456

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

dhwanilpatel
Copy link
Contributor

Signed-off-by: Dhwanil Patel dhwanip@amazon.com

Description

Backport Fix bwc for cluster manager throttling settings

Original PR: #5305

Issues Resolved

#5287

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes

@codecov-commenter
Copy link

Codecov Report

Merging #5456 (c6dcf73) into 2.x (1be8521) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #5456      +/-   ##
============================================
- Coverage     70.65%   70.53%   -0.13%     
+ Complexity    58298    58226      -72     
============================================
  Files          4700     4700              
  Lines        279094   279095       +1     
  Branches      40751    40753       +2     
============================================
- Hits         197200   196850     -350     
- Misses        65365    65842     +477     
+ Partials      16529    16403     -126     
Impacted Files Coverage Δ
...h/cluster/service/ClusterManagerTaskThrottler.java 87.83% <100.00%> (+0.16%) ⬆️
...a/org/opensearch/index/fielddata/DocValueBits.java 0.00% <0.00%> (-100.00%) ⬇️
...g/opensearch/index/analysis/CharFilterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...ns/support/MultiValuesSourceAggregatorFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...aggregations/bucket/missing/MissingAggregator.java 0.00% <0.00%> (-93.75%) ⬇️
...ch/aggregations/metrics/WeightedAvgAggregator.java 0.00% <0.00%> (-77.36%) ⬇️
...tions/bucket/missing/MissingAggregatorFactory.java 25.00% <0.00%> (-75.00%) ⬇️
...org/opensearch/index/query/SpanOrQueryBuilder.java 17.64% <0.00%> (-72.06%) ⬇️
...search/aggregations/support/MultiValuesSource.java 0.00% <0.00%> (-70.59%) ⬇️
...egations/metrics/WeightedAvgAggregatorFactory.java 0.00% <0.00%> (-62.50%) ⬇️
... and 515 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Gradle Check (Jenkins) Run Completed with:

@dhwanilpatel dhwanilpatel marked this pull request as ready for review December 6, 2022 09:30
@dhwanilpatel dhwanilpatel requested review from a team and reta as code owners December 6, 2022 09:30
@dblock dblock merged commit 95441bc into opensearch-project:2.x Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants