-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test case - string profiler via global ordinals #5652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
December 28, 2022 22:31
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5652 +/- ##
============================================
- Coverage 71.01% 70.98% -0.04%
- Complexity 58562 58621 +59
============================================
Files 4760 4760
Lines 279514 279514
Branches 40348 40348
============================================
- Hits 198501 198412 -89
- Misses 64815 64925 +110
+ Partials 16198 16177 -21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
andrross
approved these changes
Dec 28, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 28, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 30ac284) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Dec 29, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 30ac284) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal
pushed a commit
that referenced
this pull request
Jan 25, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 30ac284) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Widdis widdis@gmail.com
Description
The "string profiler via global ordinals" rest test assumes all documents are in the same segment. The four commits occasionally are entered into multiple segments. PR #2226 by @penghuo attempted to fix this using a force merge, which reduced the frequency of these failures but did not eliminate them (reproduced once in 1000 runs).
Setting the
flush
boolean totrue
in this force merge completely resolves these failures (no repro in 2000 runs).Issues Resolved
Fixes #1817
Improves fix of #2176
Check List
- [ ] New functionality includes testing.- [ ] All tests pass- [ ] New functionality has been documented.- [ ] New functionality has javadoc added- [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.