Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor buffer interval code for remote-backed indexes #6063

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Refactor buffer interval code for remote-backed indexes #6063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/src/main/java/org/opensearch/common/util/concurrent/BufferedAsyncIOProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void put(Item item, Consumer<Exception> listener) {
private void scheduleProcess() {
if (getQueue().isEmpty() == false && getPromiseSemaphore().tryAcquire()) {
try {
threadpool.schedule(this::process, getBufferInterval(), getBufferRefreshThreadPoolName());
threadpool.schedule(this::process, getBufferInterval(), getBufferProcessThreadPoolName());
} catch (Exception e) {
getLogger().error("failed to schedule process");
processSchedulingFailure(e);
Expand Down Expand Up @@ -88,6 +88,6 @@ private TimeValue getBufferInterval() {
return TimeValue.timeValueNanos(bufferInterval.getNanos() - timeSinceLastRunStartInNS);
}

protected abstract String getBufferRefreshThreadPoolName();
protected abstract String getBufferProcessThreadPoolName();

}
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/index/shard/IndexShard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3845,7 +3845,7 @@ protected void write(List<Tuple<Translog.Location, Consumer<Exception>>> candida
}

@Override
protected String getBufferRefreshThreadPoolName() {
protected String getBufferProcessThreadPoolName() {
return ThreadPool.Names.TRANSLOG_SYNC;
}
};
Expand Down
8 changes: 4 additions & 4 deletions ...er/src/test/java/org/opensearch/common/util/concurrent/BufferedAsyncIOProcessorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ protected void write(List<Tuple<Object, Consumer<Exception>>> candidates) throws
}

@Override
protected String getBufferRefreshThreadPoolName() {
protected String getBufferProcessThreadPoolName() {
return ThreadPool.Names.TRANSLOG_SYNC;
}
};
Expand Down Expand Up @@ -108,7 +108,7 @@ protected void write(List<Tuple<Object, Consumer<Exception>>> candidates) throws
}

@Override
protected String getBufferRefreshThreadPoolName() {
protected String getBufferProcessThreadPoolName() {
return ThreadPool.Names.TRANSLOG_SYNC;
}
};
Expand Down Expand Up @@ -164,7 +164,7 @@ protected void write(List<Tuple<Object, Consumer<Exception>>> candidates) throws
}

@Override
protected String getBufferRefreshThreadPoolName() {
protected String getBufferProcessThreadPoolName() {
return ThreadPool.Names.TRANSLOG_SYNC;
}
};
Expand Down Expand Up @@ -229,7 +229,7 @@ protected void write(List<Tuple<Object, Consumer<Exception>>> candidates) throws
}

@Override
protected String getBufferRefreshThreadPoolName() {
protected String getBufferProcessThreadPoolName() {
return ThreadPool.Names.TRANSLOG_SYNC;
}
};
Expand Down