Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Handle translog upload during primary relocation for remote-backed indexes (#5804) #6064

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

ashking94
Copy link
Member

  • Upload translog only if primaryMode is true

Signed-off-by: Ashish Singh ssashish@amazon.com

Description

Original PR - #5804
Solves #5795 & #5844.

Issues Resolved

Original PR - #5804
Solves #5795 & #5844.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…r remote-backed indexes (opensearch-project#5804)

* Upload translog only if primaryMode is true

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@ashking94 ashking94 marked this pull request as ready for review January 30, 2023 07:26
@ashking94 ashking94 changed the title [Remote Translog] Handle translog upload during primary relocation for remote-backed indexes (#5804) [Backport 2.x] Handle translog upload during primary relocation for remote-backed indexes (#5804) Jan 30, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation

@codecov-commenter
Copy link

Codecov Report

Merging #6064 (83926d0) into 2.x (579f1a6) will increase coverage by 0.06%.
The diff coverage is 78.12%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6064      +/-   ##
============================================
+ Coverage     70.37%   70.43%   +0.06%     
- Complexity    58890    58932      +42     
============================================
  Files          4769     4769              
  Lines        282621   282643      +22     
  Branches      41169    41171       +2     
============================================
+ Hits         198899   199087     +188     
+ Misses        67063    66925     -138     
+ Partials      16659    16631      -28     
Impacted Files Coverage Δ
...search/index/translog/InternalTranslogFactory.java 100.00% <ø> (ø)
...anslog/RemoteBlobStoreInternalTranslogFactory.java 75.00% <ø> (ø)
...earch/index/translog/WriteOnlyTranslogManager.java 40.00% <ø> (ø)
...n/java/org/opensearch/index/engine/NoOpEngine.java 60.37% <50.00%> (+0.37%) ⬆️
...va/org/opensearch/index/engine/ReadOnlyEngine.java 72.02% <50.00%> (+0.76%) ⬆️
...in/java/org/opensearch/index/shard/IndexShard.java 70.03% <58.33%> (-0.01%) ⬇️
...java/org/opensearch/index/engine/EngineConfig.java 98.46% <100.00%> (+0.04%) ⬆️
...g/opensearch/index/engine/EngineConfigFactory.java 92.85% <100.00%> (+0.10%) ⬆️
...va/org/opensearch/index/engine/InternalEngine.java 73.38% <100.00%> (-1.11%) ⬇️
.../opensearch/index/engine/NRTReplicationEngine.java 77.63% <100.00%> (+0.13%) ⬆️
... and 478 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gbbafna gbbafna merged commit 13bfdd6 into opensearch-project:2.x Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants