Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken template for issue autocuts on GH failure. #6081

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Jan 30, 2023

Signed-off-by: Marc Handalian handalm@amazon.com

Description

There were multiple GC failures post merge over the weekend. - Example: https://github.com/opensearch-project/OpenSearch/actions/runs/4028023871/jobs/6924435585. The recently introduced workflow to autocut an issue failed because of formatting. Also added [AUTOCUT] to beginning of the issue title.

Issues Resolved

closes #6085

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Marc Handalian <handalm@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member

Gradle Check (Jenkins) Run Completed with:

Flaky test failure, not related to this change.

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes" -Dtests.seed=C3BB1A9EC8A7FCD1 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ko-KR -Dtests.timezone=Africa/Asmera -Druntime.java=19

org.opensearch.cluster.service.MasterServiceTests > classMethod FAILED
    com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from SUITE scope at org.opensearch.cluster.service.MasterServiceTests: 
       1) Thread[id=121, name=opensearch[test_node][clusterManagerService#updateTask][T#1], state=WAITING, group=TGRP-MasterServiceTests]
            at java.****/jdk.internal.misc.Unsafe.park(Native Method)
            at java.****/java.util.concurrent.locks.LockSupport.park(LockSupport.java:371)
            at java.****/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionNode.block(AbstractQueuedSynchronizer.java:506)
            at java.****/java.util.concurrent.ForkJoinPool.unmanagedBlock(ForkJoinPool.java:3744)
            at java.****/java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3689)
            at java.****/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1625)
            at java.****/java.util.concurrent.PriorityBlockingQueue.take(PriorityBlockingQueue.java:535)
            at java.****/java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1070)
            at java.****/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
            at java.****/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
            at java.****/java.lang.Thread.run(Thread.java:1589)
        at __randomizedtesting.SeedInfo.seed([C3BB1A9EC8A7FCD1]:0)

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.cluster.service.MasterServiceTests" -Dtests.seed=C3BB1A9EC8A7FCD1 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en -Dtests.timezone=Etc/UTC -Druntime.java=19

org.opensearch.cluster.service.MasterServiceTests > classMethod FAILED
    com.carrotsearch.randomizedtesting.ThreadLeakError: There are still zombie threads that couldn't be terminated:
       1) Thread[id=121, name=opensearch[test_node][clusterManagerService#updateTask][T#1], state=WAITING, group=TGRP-MasterServiceTests]
            at java.****/jdk.internal.misc.Unsafe.park(Native Method)
            at java.****/java.util.concurrent.locks.LockSupport.park(LockSupport.java:371)
            at java.****/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionNode.block(AbstractQueuedSynchronizer.java:506)
            at java.****/java.util.concurrent.ForkJoinPool.unmanagedBlock(ForkJoinPool.java:3744)
            at java.****/java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3689)
            at java.****/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1625)
            at java.****/java.util.concurrent.PriorityBlockingQueue.take(PriorityBlockingQueue.java:535)
            at java.****/java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1070)
            at java.****/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
            at java.****/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
            at java.****/java.lang.Thread.run(Thread.java:1589)
        at __randomizedtesting.SeedInfo.seed([C3BB1A9EC8A7FCD1]:0)

@mch2
Copy link
Member Author

mch2 commented Jan 30, 2023

Windows precommit:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':modules:ingest-geoip:thirdPartyAudit'.
> Audit of third party dependencies failed:
    Jar Hell with the JDK:
    * #
    * # An error report file with more information is saved as:
    * # Compiler replay data is saved as:
    * # D:\a\OpenSearch\OpenSearch\modules\ingest-geoip\hs_err_pid5300.log
    * # D:\a\OpenSearch\OpenSearch\modules\ingest-geoip\replay_pid5300.log
    * # Native memory allocation (malloc) failed to allocate 153232 bytes for Chunk::new
    * # There is insufficient memory for the Java Runtime Environment to continue.

@mch2
Copy link
Member Author

mch2 commented Jan 30, 2023

Gradle Check (Jenkins) Run Completed with:

Flaky test failure, not related to this change.

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes" -Dtests.seed=C3BB1A9EC8A7FCD1 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ko-KR -Dtests.timezone=Africa/Asmera -Druntime.java=19

org.opensearch.cluster.service.MasterServiceTests > classMethod FAILED
    com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from SUITE scope at org.opensearch.cluster.service.MasterServiceTests: 
       1) Thread[id=121, name=opensearch[test_node][clusterManagerService#updateTask][T#1], state=WAITING, group=TGRP-MasterServiceTests]
            at java.****/jdk.internal.misc.Unsafe.park(Native Method)
            at java.****/java.util.concurrent.locks.LockSupport.park(LockSupport.java:371)
            at java.****/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionNode.block(AbstractQueuedSynchronizer.java:506)
            at java.****/java.util.concurrent.ForkJoinPool.unmanagedBlock(ForkJoinPool.java:3744)
            at java.****/java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3689)
            at java.****/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1625)
            at java.****/java.util.concurrent.PriorityBlockingQueue.take(PriorityBlockingQueue.java:535)
            at java.****/java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1070)
            at java.****/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
            at java.****/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
            at java.****/java.lang.Thread.run(Thread.java:1589)
        at __randomizedtesting.SeedInfo.seed([C3BB1A9EC8A7FCD1]:0)

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.cluster.service.MasterServiceTests" -Dtests.seed=C3BB1A9EC8A7FCD1 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en -Dtests.timezone=Etc/UTC -Druntime.java=19

org.opensearch.cluster.service.MasterServiceTests > classMethod FAILED
    com.carrotsearch.randomizedtesting.ThreadLeakError: There are still zombie threads that couldn't be terminated:
       1) Thread[id=121, name=opensearch[test_node][clusterManagerService#updateTask][T#1], state=WAITING, group=TGRP-MasterServiceTests]
            at java.****/jdk.internal.misc.Unsafe.park(Native Method)
            at java.****/java.util.concurrent.locks.LockSupport.park(LockSupport.java:371)
            at java.****/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionNode.block(AbstractQueuedSynchronizer.java:506)
            at java.****/java.util.concurrent.ForkJoinPool.unmanagedBlock(ForkJoinPool.java:3744)
            at java.****/java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3689)
            at java.****/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1625)
            at java.****/java.util.concurrent.PriorityBlockingQueue.take(PriorityBlockingQueue.java:535)
            at java.****/java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1070)
            at java.****/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
            at java.****/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
            at java.****/java.lang.Thread.run(Thread.java:1589)
        at __randomizedtesting.SeedInfo.seed([C3BB1A9EC8A7FCD1]:0)

#5958

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2 mch2 merged commit 4c9e927 into opensearch-project:main Jan 30, 2023
@mch2 mch2 deleted the failedcheck branch January 30, 2023 18:25
mch2 added a commit to mch2/OpenSearch that referenced this pull request Feb 2, 2023
…ject#6081)

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit 4c9e927)
mch2 added a commit that referenced this pull request Feb 2, 2023
…6157)

* Create an issue if an on push gradle check fails. (#5979)

* Create an issue if an on push gradle check fails.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add assignees.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit ad8ea03)

* Fix broken template for issue autocuts on GH failure. (#6081)

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit 4c9e927)

* Fix AUTOCUT title formatting in failed_check.md (#6100)

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit 7aea7d2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Create Issue on Push Failure Failure
3 participants