Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add support for minimum compatible version for extensions with OpenSearch #6133

Conversation

saratvemulapalli
Copy link
Member

Description

Backport of PR: #6003

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…s with OpenSearch (opensearch-project#6003)

* Refactoring extensions config to have real useable values

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Removing werror

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Removing extensions feature flag from gradle run

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Removing description

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Adding MinimumCompatible Version for extensions

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Adding changelog

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Updating changelog

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Addressing comments

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Addressing comments

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Removing debug lines

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Removing another log line

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Updating spotless

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

---------

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotAndRestore

@codecov-commenter
Copy link

Codecov Report

Merging #6133 (dfa889f) into 2.x (c116467) will increase coverage by 0.15%.
The diff coverage is 90.47%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6133      +/-   ##
============================================
+ Coverage     70.40%   70.56%   +0.15%     
- Complexity    58957    59040      +83     
============================================
  Files          4771     4771              
  Lines        282747   282715      -32     
  Branches      41181    41181              
============================================
+ Hits         199076   199492     +416     
+ Misses        67062    66568     -494     
- Partials      16609    16655      +46     
Impacted Files Coverage Δ
.../org/opensearch/extensions/ExtensionsSettings.java 42.30% <66.66%> (+0.74%) ⬆️
.../opensearch/extensions/DiscoveryExtensionNode.java 78.12% <100.00%> (+4.05%) ⬆️
...a/org/opensearch/extensions/ExtensionsManager.java 45.45% <100.00%> (-2.01%) ⬇️
...g/opensearch/index/analysis/CharFilterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/opensearch/client/indices/DataStream.java 0.00% <0.00%> (-76.09%) ⬇️
.../opensearch/client/indices/CloseIndexResponse.java 17.50% <0.00%> (-60.00%) ⬇️
.../index/shard/IndexShardNotRecoveringException.java 0.00% <0.00%> (-50.00%) ⬇️
...cluster/coordination/PublishClusterStateStats.java 33.33% <0.00%> (-37.51%) ⬇️
...nsearch/index/shard/IndexShardClosedException.java 66.66% <0.00%> (-33.34%) ⬇️
...ndex/seqno/RetentionLeaseBackgroundSyncAction.java 37.50% <0.00%> (-32.15%) ⬇️
... and 495 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrross andrross merged commit 0963950 into opensearch-project:2.x Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants