Changing SearchBP version to 2_6_0 #6216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PritLadani <pritkladani@gmail.com>
PritLadani
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Bukhtawar
reviewed
Feb 7, 2023
| SearchBackpressureState getSearchBackpressureStats(Class<? extends SearchBackpressureTask> taskType) { | ||
| SearchBackpressureState getSearchBackpressureState(Class<? extends SearchBackpressureTask> taskType) { |
There was a problem hiding this comment.
Why do we need these refactoring? Do we plan to backport this again?
There was a problem hiding this comment.
We have already backported this refactoring to 2.x. #6194
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing Search Backpressure version to 2.6 and other minor refactoring.
Issues Resolved
#5173
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: PritLadani pritkladani@gmail.com