Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding permissions for extensions directory #6561

Conversation

saratvemulapalli
Copy link
Member

Description

FeatureFlags are instantiated later in the game and which is why directory permissions for extensions folder is results into read access exceptions. This change removes the feature flag as adding permissions for extensions directory is not invasive.

java.security.AccessControlException: access denied ("java.io.FilePermission" "<OPENSEARCH_HOME>/distribution/opensearch-3.0.0-SNAPSHOT/extensions" "read")

Issues Resolved

Closes opensearch-project/opensearch-sdk-java#390

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #6561 (78dd198) into main (ef614a1) will increase coverage by 0.14%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #6561      +/-   ##
============================================
+ Coverage     70.59%   70.73%   +0.14%     
- Complexity    59032    59052      +20     
============================================
  Files          4804     4804              
  Lines        283081   283080       -1     
  Branches      40809    40808       -1     
============================================
+ Hits         199831   200230     +399     
+ Misses        66815    66359     -456     
- Partials      16435    16491      +56     
Impacted Files Coverage Δ
...c/main/java/org/opensearch/bootstrap/Security.java 32.86% <0.00%> (+0.22%) ⬆️
...index/translog/transfer/FileTransferException.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/opensearch/node/NodeClosedException.java 50.00% <0.00%> (-50.00%) ⬇️
...ava/org/opensearch/action/NoSuchNodeException.java 0.00% <0.00%> (-50.00%) ⬇️
...ch/transport/ReceiveTimeoutTransportException.java 50.00% <0.00%> (-50.00%) ⬇️
.../org/opensearch/client/indices/AnalyzeRequest.java 31.00% <0.00%> (-44.00%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-40.75%) ⬇️
...opensearch/index/reindex/BulkByScrollResponse.java 48.38% <0.00%> (-39.52%) ⬇️
...h/action/ingest/SimulateDocumentVerboseResult.java 60.71% <0.00%> (-39.29%) ⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java 56.25% <0.00%> (-37.50%) ⬇️
... and 484 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@saratvemulapalli saratvemulapalli added the backport 2.x Backport to 2.x branch label Mar 7, 2023
@saratvemulapalli saratvemulapalli merged commit 9a763e8 into opensearch-project:main Mar 7, 2023
@saratvemulapalli saratvemulapalli deleted the extensions-startup branch March 7, 2023 06:29
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6561-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9a763e86796f2a7a06e6f233608c73aaef6acd49
# Push it to GitHub
git push --set-upstream origin backport/backport-6561-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6561-to-2.x.

saratvemulapalli added a commit to saratvemulapalli/OpenSearch that referenced this pull request Mar 7, 2023
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
saratvemulapalli added a commit that referenced this pull request Mar 8, 2023
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
mingshl pushed a commit to mingshl/OpenSearch-Mingshl that referenced this pull request Mar 24, 2023
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
3 participants