-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding permissions for extensions directory #6561
Adding permissions for extensions directory #6561
Conversation
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6561 +/- ##
============================================
+ Coverage 70.59% 70.73% +0.14%
- Complexity 59032 59052 +20
============================================
Files 4804 4804
Lines 283081 283080 -1
Branches 40809 40808 -1
============================================
+ Hits 199831 200230 +399
+ Misses 66815 66359 -456
- Partials 16435 16491 +56
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6561-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9a763e86796f2a7a06e6f233608c73aaef6acd49
# Push it to GitHub
git push --set-upstream origin backport/backport-6561-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Description
FeatureFlags are instantiated later in the game and which is why directory permissions for
extensions
folder is results into read access exceptions. This change removes the feature flag as adding permissions for extensions directory is not invasive.Issues Resolved
Closes opensearch-project/opensearch-sdk-java#390
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.