-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segment Replication - Update /_cat/segment_replication API with backpressure metrics. #6674
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6674 +/- ##
============================================
- Coverage 70.77% 70.73% -0.04%
+ Complexity 59250 59231 -19
============================================
Files 4808 4809 +1
Lines 283454 283501 +47
Branches 40868 40873 +5
============================================
- Hits 200611 200538 -73
- Misses 66338 66547 +209
+ Partials 16505 16416 -89
... and 485 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…e metrics. This change updates the existing /_cat/segment_replication API to include backpressure metrics. It does this by returning stats from primary shards for its tracked replication group and merging it with metrics returned from replicas. Primary captured metrics will now appear by default, with replica per sync events showing when detailed=true is set. Signed-off-by: Marc Handalian <handalm@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Whitesource scan will be fixed with #6629 |
...c/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationStatsIT.java
Outdated
Show resolved
Hide resolved
...c/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationStatsIT.java
Show resolved
Hide resolved
...c/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationStatsIT.java
Outdated
Show resolved
Hide resolved
...c/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationStatsIT.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/SegmentReplicationShardStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/rest/action/cat/RestCatSegmentReplicationAction.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/rest/action/cat/RestCatSegmentReplicationAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6674-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 188e043585b652676a5fc6d175f81bdca0ce96df
# Push it to GitHub
git push --set-upstream origin backport/backport-6674-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…ressure metrics. (opensearch-project#6674) * Segment Replication - Update Segment Replication API with backpressure metrics. This change updates the existing /_cat/segment_replication API to include backpressure metrics. It does this by returning stats from primary shards for its tracked replication group and merging it with metrics returned from replicas. Primary captured metrics will now appear by default, with replica per sync events showing when detailed=true is set. Signed-off-by: Marc Handalian <handalm@amazon.com> * PR Feedback. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fixed current_lag header alias. Signed-off-by: Marc Handalian <handalm@amazon.com> --------- Signed-off-by: Marc Handalian <handalm@amazon.com>
…ressure metrics. (opensearch-project#6674) * Segment Replication - Update Segment Replication API with backpressure metrics. This change updates the existing /_cat/segment_replication API to include backpressure metrics. It does this by returning stats from primary shards for its tracked replication group and merging it with metrics returned from replicas. Primary captured metrics will now appear by default, with replica per sync events showing when detailed=true is set. Signed-off-by: Marc Handalian <handalm@amazon.com> * PR Feedback. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fixed current_lag header alias. Signed-off-by: Marc Handalian <handalm@amazon.com> --------- Signed-off-by: Marc Handalian <handalm@amazon.com>
…ressure metrics. (#6674) (#6741) * Segment Replication - Update Segment Replication API with backpressure metrics. This change updates the existing /_cat/segment_replication API to include backpressure metrics. It does this by returning stats from primary shards for its tracked replication group and merging it with metrics returned from replicas. Primary captured metrics will now appear by default, with replica per sync events showing when detailed=true is set. * PR Feedback. * Fixed current_lag header alias. --------- Signed-off-by: Marc Handalian <handalm@amazon.com> Co-authored-by: Marc Handalian <handalm@amazon.com>
…ressure metrics. (opensearch-project#6674) * Segment Replication - Update Segment Replication API with backpressure metrics. This change updates the existing /_cat/segment_replication API to include backpressure metrics. It does this by returning stats from primary shards for its tracked replication group and merging it with metrics returned from replicas. Primary captured metrics will now appear by default, with replica per sync events showing when detailed=true is set. Signed-off-by: Marc Handalian <handalm@amazon.com> * PR Feedback. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fixed current_lag header alias. Signed-off-by: Marc Handalian <handalm@amazon.com> --------- Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Description
This change updates the existing /_cat/segment_replication API to include backpressure metrics. It does this by returning stats from primary shards for its tracked replication group and merging it with metrics returned from replicas. Primary captured metrics will now appear by default, with replica per sync events showing when detailed=true is set.
Issues Resolved
Resolves #4478
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.