Fix LocalTranslogTests.testWithRandomException test scenario

[mitrofmep]

Description

Set TragicException in case of simulated Runtime Exception for asserting and passing test LocalTranslogTests.testWithRandomException

Issues Resolved

Resolves #6625

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/12635/
• CommitID: 8aa3e72
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[dblock]

Please sign DCO/iterate to green. Thanks!

[mitrofmep]

Please sign DCO/iterate to green. Thanks!

Done)

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/12904/
• CommitID: 0269379

[codecov-commenter]

Codecov Report

Merging #6748 (42f2d8a) into main (59e881b) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 42f2d8a differs from pull request most recent head 964887f. Consider uploading reports for the commit 964887f to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #6748      +/-   ##
============================================
- Coverage     70.77%   70.76%   -0.01%     
+ Complexity    59270    59236      -34     
============================================
  Files          4822     4822              
  Lines        283940   283940              
  Branches      40947    40947              
============================================
- Hits         200963   200935      -28     
+ Misses        66454    66402      -52     
- Partials      16523    16603      +80     

see 473 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dblock]

@mitrofmep Do you think you could add a test that always hits this code?

[mitrofmep]

@mitrofmep Do you think you could add a test that always hits this code?

Sure! Proceeding from this case, is it ok if I'll create a copy of this test LocalTranslogTests.testWithRandomException, but change random values to exact values, that are passed to test in case of "problem" seed?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.split/30_copy_settings/Copy settings during split index}
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.shrink/30_copy_settings/Copy settings during shrink index}

• URL: https://build.ci.opensearch.org/job/gradle-check/12975/
• CommitID: 055c727
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[dbwiddis]

@mitrofmep Do you think you could add a test that always hits this code?

Hey @dblock I independently tracked this one down, and the existing random tests do trigger this; it's 100% reproducible with the seed given in the failed log builds. (Call heirarchy confirms it fails 1 in 100 times.) I don't think an additional test is needed, and I think the fix is correct here (the test expects the failure tracked in "tragic" but it's just a plain exception.

[dbwiddis]

I might note that the "expected" and "actual" fields in the assertEquals() associated with this failure (and all in this test method) are reversed, which makes debugging slightly confusing. I wouldn't mind if those were switched to their correct order in this PR.

[dblock]

@mitrofmep Do you think you could add a test that always hits this code?

Hey @dblock I independently tracked this one down, and the existing random tests do trigger this; it's 100% reproducible with the seed given in the failed log builds. (Call heirarchy confirms it fails 1 in 100 times.) I don't think an additional test is needed, and I think the fix is correct here (the test expects the failure tracked in "tragic" but it's just a plain exception.

Let's agree to disagree. When tests pass 99% of the time means we can introduce a regression and catch it only 1% of the time (we got lucky here!). I'll merge either way.

[dblock]

@mitrofmep LMK if you want me to merge as is or fix the order of the check that @dbwiddis suggests (and write a test that always fails without this fix as I do? :))

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/13484/
• CommitID: 39758ea
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/13485/
• CommitID: 42f2d8a
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/13482/
• CommitID: 24bdfb0

[mitrofmep]

@mitrofmep LMK if you want me to merge as is or fix the order of the check that @dbwiddis suggests (and write a test that always fails without this fix as I do? :))

Hello, @dblock! Could you merge it as is for now, and we can add this always falling test later. I also reversed "actual" and "expected" fields, as @dbwiddis mentioned.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

• URL: https://build.ci.opensearch.org/job/gradle-check/13483/
• CommitID: 42f2d8a
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/13486/
• CommitID: 964887f

[mitrofmep]

@dblock, is it okay for merging now, or should I add something else?