[Backport 2.x] [Extensions] Add DynamicActionRegistry to ActionModule #6829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add dynamic action registry to ActionModule Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update registration of transport actions Signed-off-by: Daniel Widdis <widdis@gmail.com> * Generate transport actions dynamically Signed-off-by: Daniel Widdis <widdis@gmail.com> * Refactor to combine registry internals Signed-off-by: Daniel Widdis <widdis@gmail.com> * Finally figured out the generics (or lack thereof) Signed-off-by: Daniel Widdis <widdis@gmail.com> * ExtensionProxyAction is dead! Long live ExtensionAction! Signed-off-by: Daniel Widdis <widdis@gmail.com> * Simplify ExtensionTransportActionHandler, fix compile issues Signed-off-by: Daniel Widdis <widdis@gmail.com> * Maybe tests will pass with this commit Signed-off-by: Daniel Widdis <widdis@gmail.com> * I guess you can't use null as a key in a map Signed-off-by: Daniel Widdis <widdis@gmail.com> * Lazy test setup, but this should finally work Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add Tests Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix TransportActionRequestFromExtension inheritance Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix return type for transport actions from extensions Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix ParametersInWrongOrderError and add some preemptive null handling Signed-off-by: Daniel Widdis <widdis@gmail.com> * NPE is not expected result if params are in correct order Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove redundant class and string parsing, add success boolean Signed-off-by: Daniel Widdis <widdis@gmail.com> * Last fix of params out of order. Working test case! Signed-off-by: Daniel Widdis <widdis@gmail.com> * Code worked, tests didn't. This is finally done (I think) Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add more detail to comments on immutable vs. dynamic maps Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add StreamInput getter to ExtensionActionResponse Signed-off-by: Daniel Widdis <widdis@gmail.com> * Generalize dynamic action registration Signed-off-by: Daniel Widdis <widdis@gmail.com> * Comment and naming fixes Signed-off-by: Daniel Widdis <widdis@gmail.com> * Register method renaming Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add generic type parameters Signed-off-by: Daniel Widdis <widdis@gmail.com> * Improve/simplify which parameter types get passed Signed-off-by: Daniel Widdis <widdis@gmail.com> * Revert removal of ProxyAction and changes to transport and requests Signed-off-by: Daniel Widdis <widdis@gmail.com> * Wrap ExtensionTransportResponse in a class denoting success Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove generic types as they are incompatible with Guice injection Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix response handling, it works (again) Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix up comments and remove debug logging Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 9febe10) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
reta
approved these changes
Mar 24, 2023
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #6829 +/- ##
============================================
- Coverage 70.50% 70.48% -0.02%
- Complexity 59453 59477 +24
============================================
Files 4806 4808 +2
Lines 285299 285404 +105
Branches 41478 41489 +11
============================================
+ Hits 201141 201163 +22
- Misses 67346 67454 +108
+ Partials 16812 16787 -25
... and 471 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Rishikesh1159
added a commit
to Rishikesh1159/OpenSearch
that referenced
this pull request
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9febe10 from #6734.