Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Enable numeric sort optimization support for all numeric types #6849

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e8425fc from #6424.

* Adding numeric optimization support for all numeric types

Signed-off-by: gashutos <gashutos@amazon.com>

* modifying CHANGELOG.md

Signed-off-by: gashutos <gashutos@amazon.com>

* Handling multi-cluster scenario where SortField serialization was failing

Signed-off-by: gashutos <gashutos@amazon.com>

* Fixing javadoc errors

Signed-off-by: gashutos <gashutos@amazon.com>

* Fixing nested sort integ tests

Signed-off-by: gashutos <gashutos@amazon.com>

* Stremlining behaviour of custom comparator tests too

Signed-off-by: gashutos <gashutos@amazon.com>

* Adding more integ tests for IntValuesComparatorSource & fixing few ITs

Signed-off-by: gashutos <gashutos@amazon.com>

* Fixing few more integ tests

Signed-off-by: gashutos <gashutos@amazon.com>

* Streamlining applySortWidening method with CreateSort and avoid modifying cteated objects of sort

Signed-off-by: gashutos <gashutos@amazon.com>

* Correcting licence header

Signed-off-by: gashutos <gashutos@amazon.com>

---------

Signed-off-by: gashutos <gashutos@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
(cherry picked from commit e8425fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #6849 (cb58918) into 2.x (8efb44d) will decrease coverage by 0.03%.
The diff coverage is 70.52%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6849      +/-   ##
============================================
- Coverage     70.47%   70.45%   -0.03%     
+ Complexity    59470    59454      -16     
============================================
  Files          4806     4808       +2     
  Lines        285307   285371      +64     
  Branches      41479    41490      +11     
============================================
- Hits         201082   201048      -34     
- Misses        67473    67507      +34     
- Partials      16752    16816      +64     
Impacted Files Coverage Δ
...main/java/org/opensearch/common/lucene/Lucene.java 67.08% <0.00%> (-0.21%) ⬇️
...earch/search/sort/SortedWiderNumericSortField.java 30.76% <30.76%> (ø)
...ata/fieldcomparator/IntValuesComparatorSource.java 50.00% <50.00%> (ø)
...pensearch/action/search/SearchPhaseController.java 78.97% <78.94%> (-5.89%) ⬇️
.../java/org/opensearch/search/sort/BucketedSort.java 94.92% <95.83%> (+0.12%) ⬆️
...nsearch/index/fielddata/IndexNumericFieldData.java 85.10% <100.00%> (+1.49%) ⬆️

... and 474 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reta reta merged commit 8356d2b into 2.x Mar 28, 2023
@github-actions github-actions bot deleted the backport/backport-6424-to-2.x branch March 28, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants