Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Upgrade forbiddenapis to 3.5.1 (#6840) #6898

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Mar 30, 2023

Backport #6840 to 2.x

* Upgrade forbiddenapis to 3.5

Signed-off-by: Uwe Schindler <uwe@thetaphi.de>

* Update to forbiddenapis 3.5.1 and change regex for missing classes

Signed-off-by: Uwe Schindler <uwe@thetaphi.de>

---------

Signed-off-by: Uwe Schindler <uwe@thetaphi.de>
(cherry picked from commit 37b37c5)
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator Author

reta commented Mar 30, 2023

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE x

* **URL:** https://build.ci.opensearch.org/job/gradle-check/13110/

* **CommitID:** [5622e22](https://github.com/opensearch-project/OpenSearch/commit/5622e2243d72668f7a09a1a61da4e6a2bb311e0e)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

Hm ...

java.lang.AssertionError: 
Expected: iterable containing ["Synced flush is deprecated and will be removed in 3.0. Use flush at _/flush or /{index}/_flush instead."]
     but: no item was "Synced flush is deprecated and will be removed in 3.0. Use flush at _/flush or /{index}/_flush instead."

The 1.3.10 should have the changes: #6872

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator Author

reta commented Mar 31, 2023

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE x

* **URL:** https://build.ci.opensearch.org/job/gradle-check/13145/

* **CommitID:** [5622e22](https://github.com/opensearch-project/OpenSearch/commit/5622e2243d72668f7a09a1a61da4e6a2bb311e0e)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

Should be fixed by #6918

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.shrink/30_copy_settings/Copy settings during shrink index}

@codecov-commenter
Copy link

Codecov Report

Merging #6898 (5622e22) into 2.x (ac79a63) will decrease coverage by 0.03%.
The diff coverage is 31.93%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6898      +/-   ##
============================================
- Coverage     70.41%   70.38%   -0.03%     
+ Complexity    59480    59476       -4     
============================================
  Files          4810     4811       +1     
  Lines        285453   285551      +98     
  Branches      41503    41511       +8     
============================================
- Hits         200993   200985       -8     
- Misses        67704    67789      +85     
- Partials      16756    16777      +21     
Impacted Files Coverage Δ
...ark/store/remote/filecache/FileCacheBenchmark.java 0.00% <0.00%> (ø)
...ensearch/gradle/precommit/ThirdPartyAuditTask.java 0.00% <0.00%> (ø)
...pensearch/ingest/useragent/UserAgentProcessor.java 63.41% <ø> (ø)
.../index/reindex/AbstractBaseReindexRestHandler.java 6.66% <ø> (+0.69%) ⬆️
...on/admin/indices/forcemerge/ForceMergeRequest.java 48.71% <0.00%> (-4.06%) ⬇️
...ensearch/index/mapper/ParametrizedFieldMapper.java 98.59% <ø> (ø)
.../java/org/opensearch/index/mapper/TypeParsers.java 81.39% <ø> (ø)
...main/java/org/opensearch/rest/BaseRestHandler.java 69.33% <0.00%> (-7.14%) ⬇️
...rest/action/admin/indices/RestOpenIndexAction.java 34.78% <0.00%> (-22.37%) ⬇️
...va/org/opensearch/index/mapper/MapperTestCase.java 95.33% <ø> (ø)
... and 11 more

... and 463 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reta reta merged commit e96b556 into opensearch-project:2.x Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants