Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Refactor] Remove CollectionUtils.sortAndDedup and use java TreeSet instead of hppc ObjectArrayList #6902

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 4859e15 from #6884.

…nstead of hppc ObjectArrayList (#6884)

* [Refactor] CollectionUtils.sortAndDedup to use java lists

HPPC ObjectArrayLists provide no benefit in CollectionUtils.sortAndDedup and
adds an unnecessary library dependency. This commit removes that dependency on
hppc by switching the sortAndDeup method to use java.util.Lists.
BinaryFieldMapper logic is updated to use the generic java list.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

* close BytesStreamOutput in CustomBinaryDocValuesField.bytes

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

---------

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 4859e15)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.shrink/30_copy_settings/Copy settings during shrink index}

@codecov-commenter
Copy link

Codecov Report

Merging #6902 (5353baa) into 2.x (ac79a63) will decrease coverage by 0.12%.
The diff coverage is 43.57%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6902      +/-   ##
============================================
- Coverage     70.41%   70.30%   -0.12%     
+ Complexity    59480    59437      -43     
============================================
  Files          4810     4811       +1     
  Lines        285453   285537      +84     
  Branches      41503    41508       +5     
============================================
- Hits         200993   200735     -258     
- Misses        67704    68037     +333     
- Partials      16756    16765       +9     
Impacted Files Coverage Δ
...ark/store/remote/filecache/FileCacheBenchmark.java 0.00% <0.00%> (ø)
...pensearch/ingest/useragent/UserAgentProcessor.java 63.41% <ø> (ø)
.../index/reindex/AbstractBaseReindexRestHandler.java 6.66% <ø> (+0.69%) ⬆️
...on/admin/indices/forcemerge/ForceMergeRequest.java 48.71% <0.00%> (-4.06%) ⬇️
...ensearch/index/mapper/ParametrizedFieldMapper.java 98.59% <ø> (ø)
.../java/org/opensearch/index/mapper/TypeParsers.java 81.39% <ø> (ø)
...main/java/org/opensearch/rest/BaseRestHandler.java 69.33% <0.00%> (-7.14%) ⬇️
...rest/action/admin/indices/RestOpenIndexAction.java 34.78% <0.00%> (-22.37%) ⬇️
...va/org/opensearch/index/mapper/MapperTestCase.java 95.33% <ø> (ø)
...g/opensearch/test/rest/OpenSearchRestTestCase.java 3.93% <ø> (ø)
... and 11 more

... and 466 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reta reta merged commit 3141c57 into 2.x Apr 1, 2023
@github-actions github-actions bot deleted the backport/backport-6884-to-2.x branch April 1, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants