[BUG] Zstd new codec is a breaking change for kNN plugin: move custom-codecs from sandbox/modules to sandbox/plugins (so it won't be installed automatically)

[reta]

Description

Move custom-codecs from sandbox/modules to sandbox/plugins (so it won't be installed automatically)

Issues Resolved

Closes #7012

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[reta]

@mulugetam please

[reta]

Skipping changelog since the feature was not released yet

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/13549/
• CommitID: a1a7732
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[reta]

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE x

* **URL:** https://build.ci.opensearch.org/job/gradle-check/13549/

* **CommitID:** [a1a7732](https://github.com/opensearch-project/OpenSearch/commit/a1a7732c3d4a7b4999f2eb4cc2a1b15e7a5d97ab)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

Hehe ...

Execution failed for task ':test:fixtures:gcs-fixture:composeBuild'.
> Exit-code 1 when calling /usr/bin/docker-compose, stdout: Step 1/11 : FROM ubuntu:18.04

[martin-gaievski]

please add "backport 2.x" label, original PR got backported to 2.x :( 3accec8

[reta]

please add "backport 2.x" label, original PR got backported to 2.x :( 3accec8

Yes, that's after merge, no worries :) We just need to pass the Docker rate limit ...

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/13553/
• CommitID: a1a7732
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/13559/
• CommitID: a1a7732
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/13566/
• CommitID: a1a7732
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[peterzhuamazon]

Hi @reta

I deployed the fix now to Jenkins.
If it fails again try to rerun.
It should login as a readonly user and increase the pull limit.

Sorry about it.
Thanks.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/13568/
• CommitID: a1a7732
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/13573/
• CommitID: a1a7732

[codecov-commenter]

Codecov Report

Merging #7014 (a1a7732) into main (59e881b) will decrease coverage by 0.18%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #7014      +/-   ##
============================================
- Coverage     70.77%   70.60%   -0.18%     
+ Complexity    59270    59211      -59     
============================================
  Files          4822     4823       +1     
  Lines        283940   283985      +45     
  Branches      40947    40953       +6     
============================================
- Hits         200963   200497     -466     
- Misses        66454    66985     +531     
+ Partials      16523    16503      -20     

Impacted Files	Coverage Δ
...ch/index/codec/customcodecs/CustomCodecPlugin.java	0.00% <ø> (ø)
...h/index/codec/customcodecs/CustomCodecService.java	0.00% <ø> (ø)
.../codec/customcodecs/CustomCodecServiceFactory.java	0.00% <ø> (ø)
.../index/codec/customcodecs/Lucene95CustomCodec.java	60.00% <ø> (ø)
...customcodecs/Lucene95CustomStoredFieldsFormat.java	25.00% <ø> (ø)
...ustomcodecs/PerFieldMappingPostingFormatCodec.java	0.00% <ø> (ø)
...opensearch/index/codec/customcodecs/ZstdCodec.java	80.00% <ø> (ø)
.../index/codec/customcodecs/ZstdCompressionMode.java	84.09% <ø> (ø)
...arch/index/codec/customcodecs/ZstdNoDictCodec.java	80.00% <ø> (ø)
.../codec/customcodecs/ZstdNoDictCompressionMode.java	76.71% <ø> (ø)
... and 5 more

... and 482 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.