[Segment Replication] Prevent store read for clean up post segment replication and reader manager close operation #7044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamer-89
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
mch2
reviewed
Apr 7, 2023
6 tasks
dreamer-89
force-pushed
the
pit_improvement
branch
from
00f2c71 to
c426ca0
Compare
Gradle Check (Jenkins) Run Completed with:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
dreamer-89
force-pushed
the
pit_improvement
branch
from
ab54956 to
636fdb6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…plication and reader manager close operation Signed-off-by: Suraj Singh <surajrider@gmail.com>
…icaTracker Signed-off-by: Suraj Singh <surajrider@gmail.com>
…deletion Signed-off-by: Suraj Singh <surajrider@gmail.com>
…ed file deletion" This reverts commit b338828. Signed-off-by: Suraj Singh <surajrider@gmail.com>
…used cleanupAndPreserveLatestCommitPoint Signed-off-by: Suraj Singh <surajrider@gmail.com>
…ition Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
dreamer-89
force-pushed
the
pit_improvement
branch
from
9e6d285 to
9bc1877
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Gradle Check (Jenkins) Run Completed with:
|
|
Performed benchmark and see perf degradation. SettingsResultBaseline: main The nodes were running with |
6 tasks
|
See improvements with latest run, used 4gb jvm heap size. @mch2 : I think we can go ahead with this change ? Benchmark comparisionThere is improvement in the cumulative indexing time, throughput and latency numbers for EBS Read/WriteThere is no significant drop in EBS reads/writes both count/bytes. Baseline: Started 12pm PDT Metric Bytes
Metric Count
|
This was referenced Apr 13, 2023
|
This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an improvement on changes introduced in #6765, where clean up operations relies on expensive disk reads (1. For loading store metadata map for in memory segment infos, 2. read latest committed segment infos). It introduces a new utility in store which allows clean up based on reference counts. This PR changes:
Issues Resolved
Resolves #7043
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.