Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snapshot Interop] Add Changes in Create Snapshot Flow for remote store interoperability. #7118

Merged
merged 8 commits into from
Jun 8, 2023
Merged

[Snapshot Interop] Add Changes in Create Snapshot Flow for remote store interoperability. #7118

merged 8 commits into from
Jun 8, 2023

Conversation

harishbhakuni
Copy link
Contributor

@harishbhakuni harishbhakuni commented Apr 12, 2023 •
edited
Loading

Description

Changes in Create Snapshot API Required for #6575.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@harishbhakuni harishbhakuni changed the title Create snap flow [Snapshot Interop] Add Changes in Create Snapshot Flow for remote store interoperability. Apr 12, 2023
@harishbhakuni harishbhakuni marked this pull request as ready for review April 12, 2023 02:17
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

sohami
sohami requested changes Apr 17, 2023
View reviewed changes
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/cluster/SnapshotsInProgress.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/cluster/SnapshotsInProgress.java Outdated Show resolved Hide resolved
.../java/org/opensearch/index/snapshots/blobstore/BlobStoreRemStoreBasedIndexShardSnapshot.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/index/shard/IndexShard.java Outdated Show resolved Hide resolved
.../java/org/opensearch/index/snapshots/blobstore/BlobStoreRemStoreBasedIndexShardSnapshot.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/repositories/Repository.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/repositories/Repository.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/repositories/Repository.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/repositories/ShardGenerations.java Outdated Show resolved Hide resolved
@adriens adriens mentioned this pull request Apr 19, 2023
Closed
This was referenced May 10, 2023
Merged
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

Harish Bhakuni added 8 commits June 7, 2023 14:30
[Snapshot Interop] Add Changes in Create Snapshot Flow for remote sto…
8430611 
…re interoperability.

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Address PR Comments.
3fcedb7 
Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Address PR Comments and add tests for create snapshot api
bec444b 
Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Address PR Comments and improve Test Coverage
b8b63ba 
Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Address PR Comments
8163f45 
Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Address PR Comments
b021371 
Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Address PR Comments
fe70d7d 
Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Address PR Comments
c3ef955 
Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu

@gbbafna gbbafna merged commit 1803fd9 into opensearch-project:main Jun 8, 2023
dblock pushed a commit to dblock/OpenSearch that referenced this pull request Jun 8, 2023
@harishbhakuni @dblock
[Snapshot Interop] Add Changes in Create Snapshot Flow for remote sto…
5f6aa30 
…re interoperability. (opensearch-project#7118)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
sandeshkr419 pushed a commit to sandeshkr419/OpenSearch that referenced this pull request Jun 8, 2023
@harishbhakuni @sandeshkr419
[Snapshot Interop] Add Changes in Create Snapshot Flow for remote sto…
0bdedb5 
…re interoperability. (opensearch-project#7118)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
harishbhakuni added a commit to harishbhakuni/OpenSearch that referenced this pull request Jun 15, 2023
@harishbhakuni
[Backport 2.x] [Snapshot Interop] Add Changes in Create Snapshot Flow…
6a2f63e 
… for remote store interoperability. (opensearch-project#7118)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
harishbhakuni pushed a commit to harishbhakuni/OpenSearch that referenced this pull request Jun 15, 2023
[Backport 2.x] [Snapshot Interop] Add Changes in Create Snapshot Flow…
a6bdf3e 
… for remote store interoperability. (opensearch-project#7118)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
@harishbhakuni harishbhakuni mentioned this pull request Jun 15, 2023
Merged
6 tasks
harishbhakuni pushed a commit to harishbhakuni/OpenSearch that referenced this pull request Jun 15, 2023
[Backport 2.x] [Snapshot Interop] Add Changes in Create Snapshot Flow…
f01ae9b 
… for remote store interoperability. (opensearch-project#7118)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
harishbhakuni pushed a commit to harishbhakuni/OpenSearch that referenced this pull request Jun 15, 2023
[Backport 2.x] [Snapshot Interop] Add Changes in Create Snapshot Flow…
22084bd 
… for remote store interoperability. (opensearch-project#7118)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
harishbhakuni pushed a commit to harishbhakuni/OpenSearch that referenced this pull request Jun 15, 2023
[Backport 2.x] [Snapshot Interop] Add Changes in Create Snapshot Flow…
0a9c05f 
… for remote store interoperability. (opensearch-project#7118)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
@zhichao-aws zhichao-aws mentioned this pull request Jun 26, 2023
Closed
This was referenced Jul 21, 2023
Closed
Closed
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@harishbhakuni @shiv0408
[Snapshot Interop] Add Changes in Create Snapshot Flow for remote sto…
186ccca 
…re interoperability. (opensearch-project#7118)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@kasundra07 kasundra07 kasundra07 left review comments

@Bukhtawar Bukhtawar Bukhtawar left review comments

@sohami sohami sohami approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@xuezhou25 xuezhou25 Awaiting requested review from xuezhou25

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harishbhakuni @gbbafna @Bukhtawar @sohami @kasundra07