-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Add S3 async upload utilities and models #7217
Merged
gbbafna
merged 4 commits into
opensearch-project:main
from
raghuvanshraj:multi-part-upload-plugin-pr-2
Jul 12, 2023
Merged
[Remote Store] Add S3 async upload utilities and models #7217
gbbafna
merged 4 commits into
opensearch-project:main
from
raghuvanshraj:multi-part-upload-plugin-pr-2
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
6 tasks
mgodwan
reviewed
Apr 19, 2023
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/AmazonAsyncS3Reference.java
Outdated
Show resolved
Hide resolved
dblock
reviewed
Apr 20, 2023
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/AmazonAsyncS3Reference.java
Outdated
Show resolved
Hide resolved
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/AmazonAsyncS3Reference.java
Outdated
Show resolved
Hide resolved
raghuvanshraj
force-pushed
the
multi-part-upload-plugin-pr-2
branch
from
April 24, 2023 18:14
1b6db1f
to
e29d3b6
Compare
Gradle Check (Jenkins) Run Completed with:
|
raghuvanshraj
force-pushed
the
multi-part-upload-plugin-pr-2
branch
from
May 4, 2023 06:53
e29d3b6
to
ea5db84
Compare
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
reviewed
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still continuing with the review. these are quite involved changes and would need a comprehensive test plan/coverage as well .
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3AsyncService.java
Show resolved
Hide resolved
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3ClientSettings.java
Show resolved
Hide resolved
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncUploadUtils.java
Outdated
Show resolved
Hide resolved
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncUploadUtils.java
Outdated
Show resolved
Hide resolved
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncUploadUtils.java
Outdated
Show resolved
Hide resolved
...epository-s3/src/main/java/org/opensearch/repositories/s3/async/OpenSearchThreadFactory.java
Outdated
Show resolved
Hide resolved
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncUploadUtils.java
Outdated
Show resolved
Hide resolved
raghuvanshraj
force-pushed
the
multi-part-upload-plugin-pr-2
branch
from
May 24, 2023 15:53
ea5db84
to
530d43e
Compare
Gradle Check (Jenkins) Run Completed with:
|
raghuvanshraj
force-pushed
the
multi-part-upload-plugin-pr-2
branch
from
May 25, 2023 03:49
530d43e
to
4e5d98a
Compare
Gradle Check (Jenkins) Run Completed with:
|
raghuvanshraj
changed the title
Add S3 async upload utilities and models
[Remote Store] Add S3 async upload utilities and models
May 25, 2023
raghuvanshraj
force-pushed
the
multi-part-upload-plugin-pr-2
branch
from
May 25, 2023 08:04
4e5d98a
to
6c12571
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7217 +/- ##
============================================
- Coverage 70.95% 70.90% -0.05%
- Complexity 57056 57098 +42
============================================
Files 4759 4768 +9
Lines 269691 270169 +478
Branches 39454 39495 +41
============================================
+ Hits 191359 191564 +205
- Misses 62184 62412 +228
- Partials 16148 16193 +45
|
raghuvanshraj
force-pushed
the
multi-part-upload-plugin-pr-2
branch
from
May 29, 2023 01:58
6c12571
to
a9488f3
Compare
Gradle Check (Jenkins) Run Completed with:
|
raghuvanshraj
force-pushed
the
multi-part-upload-plugin-pr-2
branch
from
May 29, 2023 12:56
a9488f3
to
432171d
Compare
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
reviewed
Jun 1, 2023
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncUploadUtils.java
Outdated
Show resolved
Hide resolved
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncUploadUtils.java
Outdated
Show resolved
Hide resolved
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncUploadUtils.java
Outdated
Show resolved
Hide resolved
...epository-s3/src/main/java/org/opensearch/repositories/s3/async/OpenSearchThreadFactory.java
Outdated
Show resolved
Hide resolved
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncUploadUtils.java
Outdated
Show resolved
Hide resolved
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncUploadUtils.java
Outdated
Show resolved
Hide resolved
raghuvanshraj
force-pushed
the
multi-part-upload-plugin-pr-2
branch
from
June 5, 2023 08:15
432171d
to
6aad504
Compare
Gradle Check (Jenkins) Run Completed with:
|
raghuvanshraj
force-pushed
the
multi-part-upload-plugin-pr-2
branch
from
June 5, 2023 10:54
6aad504
to
6f4b0b9
Compare
Gradle Check (Jenkins) Run Completed with:
|
raghuvanshraj
force-pushed
the
multi-part-upload-plugin-pr-2
branch
from
June 15, 2023 08:05
6f4b0b9
to
f06995b
Compare
Gradle Check (Jenkins) Run Completed with:
|
raghuvanshraj
force-pushed
the
multi-part-upload-plugin-pr-2
branch
from
June 15, 2023 09:29
f06995b
to
630f250
Compare
raghuvanshraj
requested review from
andrross,
CEHENKLE,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
July 12, 2023 07:46
Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
approved these changes
Jul 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com> Co-authored-by: Vikas Bansal <vikasvb@amazon.com> (cherry picked from commit c40323b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dzane17
pushed a commit
to dzane17/OpenSearch
that referenced
this pull request
Jul 12, 2023
…roject#7217) Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com> Co-authored-by: Vikas Bansal <vikasvb@amazon.com>
gbbafna
pushed a commit
that referenced
this pull request
Jul 13, 2023
buddharajusahil
pushed a commit
to buddharajusahil/OpenSearch
that referenced
this pull request
Jul 18, 2023
…roject#7217) Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com> Co-authored-by: Vikas Bansal <vikasvb@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
…roject#7217) Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com> Co-authored-by: Vikas Bansal <vikasvb@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…roject#7217) Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com> Co-authored-by: Vikas Bansal <vikasvb@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits: @vikasvb90 and @itiyamas for the design and core implementations of the feature.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.