Fixing error: adding a new/forgotten parameter to the configuration for checking the config on startup in plugins/repository-s3

[nice-redbull]

Description

Fixing error: adding a new/forgotten parameter to the configuration for checking the config on startup.

The error fixes the situation that arises when configuring a proxy for accessing the S3 service. When setting up the proxy, the proxy.type is required, but this parameter causes an error upon node startup. This change rectifies the current situation and ensures behavior as described in the documentation.

This modification has already been tested on our systems.

Related Issues

#2160

s3.client.default.proxy.type
repository-s3

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• [?] Commits are signed per the DCO using --signoff
• [ x ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[nice-redbull]

@willyborankin

[reta]

@nice-redbull could you please:

• add CHANGELOG.md entry (under Unreleased 2.x)
• add test case for the issue

[nice-redbull]

@nice-redbull could you please:

* add CHANGELOG.md entry (under `Unreleased 2.x`)

ok

* add test case for the issue

I have no idea how to do it :-) maybe a @willyborankin will help?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/16901/
• CommitID: 2a40ebe
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu

• URL: https://build.ci.opensearch.org/job/gradle-check/16904/
• CommitID: 2afc0a9
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #7924 (2afc0a9) into main (8dd5461) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 2afc0a9 differs from pull request most recent head eedf4e7. Consider uploading reports for the commit eedf4e7 to get more accurate results

@@             Coverage Diff              @@
##               main    #7924      +/-   ##
============================================
+ Coverage     70.75%   70.82%   +0.07%     
- Complexity    56236    56245       +9     
============================================
  Files          4689     4689              
  Lines        266324   266324              
  Branches      39087    39087              
============================================
+ Hits         188425   188626     +201     
+ Misses        61949    61668     -281     
- Partials      15950    16030      +80     

Impacted Files	Coverage Δ
...opensearch/repositories/s3/S3RepositoryPlugin.java	0.00% <ø> (ø)

... and 461 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure

• URL: https://build.ci.opensearch.org/job/gradle-check/16908/
• CommitID: eedf4e7
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[dblock]

This could use a test @nice-redbull, maybe try writing one? The initial problem states that when setting up the proxy, you should be getting a "the proxy.type is required" error. If I undo this change no tests fail, so we can easily re-introduce a regression if we're not careful.

[reta]

This could use a test @nice-redbull, maybe try writing one? The initial problem states that when setting up the proxy, you should be getting a "the proxy.type is required" error. If I undo this change no tests fail, so we can easily re-introduce a regression if we're not careful.

@dblock I have added proxy to test settings here [1] - the tests are failing on main since the proxy type was not a recognizable property.

[1] https://github.com/opensearch-project/OpenSearch/pull/7924/files#diff-0e02bc404b49fa24e689c323473778abf40549bbacd9473ac0c192331e53bf0dR143

[dblock]

Aha I see, thanks @reta!