-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with delete shard routing weights on node restart #8057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
imRishN
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
June 14, 2023 09:22
Bukhtawar
reviewed
Jun 14, 2023
server/src/internalClusterTest/java/org/opensearch/cluster/routing/WeightedRoutingIT.java
Show resolved
Hide resolved
Bukhtawar
approved these changes
Jun 14, 2023
gbbafna
reviewed
Jun 14, 2023
server/src/main/java/org/opensearch/cluster/routing/WeightedRouting.java
Outdated
Show resolved
Hide resolved
gbbafna
approved these changes
Jun 14, 2023
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8057 +/- ##
============================================
- Coverage 70.92% 70.90% -0.02%
+ Complexity 56603 56571 -32
============================================
Files 4721 4721
Lines 267473 267473
Branches 39211 39211
============================================
- Hits 189713 189661 -52
- Misses 61767 61824 +57
+ Partials 15993 15988 -5
|
imRishN
changed the title
Fix bug with Delete shard routing weights on node restart
Fix bug with delete shard routing weights on node restart
Jun 14, 2023
Gradle Check (Jenkins) Run Completed with:
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
Signed-off-by: Rishab Nahata <rnnahata@amazon.com> (cherry picked from commit 87e34a3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Jun 15, 2023
) (cherry picked from commit 87e34a3) Signed-off-by: Rishab Nahata <rnnahata@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…-project#8057) (opensearch-project#8075) (cherry picked from commit 87e34a3) Signed-off-by: Rishab Nahata <rnnahata@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
imRishN
added a commit
to imRishN/OpenSearch
that referenced
this pull request
Jun 27, 2023
…-project#8057) Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…-project#8057) Signed-off-by: Rishab Nahata <rnnahata@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a node is restarted after deleting the shard routing weights, the node fails to come up due to NPE encountered while reading WRR metadata. This PR fixes the bug
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.