-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Serverless common classes to libraries #8065
Conversation
Gradle Check (Jenkins) Run Completed with:
|
I think this change should have a changelog entry. |
We haven't decided if these refactors will be backported to 2.x yet so changlog isn't being updated yet. That will be done in bulk if/when we decide which version the refactoring will be released. |
libs/core/src/main/java/org/opensearch/core/common/StopWatch.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
0a08916
to
6ecc26a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8065 +/- ##
============================================
+ Coverage 70.85% 70.97% +0.11%
- Complexity 56553 56672 +119
============================================
Files 4722 4722
Lines 267594 267594
Branches 39212 39212
============================================
+ Hits 189600 189912 +312
+ Misses 61983 61678 -305
+ Partials 16011 16004 -7
|
6ecc26a
to
51ce245
Compare
Gradle Check (Jenkins) Run Completed with:
|
51ce245
to
40ebe87
Compare
Unrelated BWC failures... rebased and pushed update. |
Gradle Check (Jenkins) Run Completed with:
|
This commit refactors common classes from the server module common package to the common and core library so they can be used across serverless and cloud native implementations without depending on the server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
40ebe87
to
fe0d40f
Compare
Gradle Check (Jenkins) Run Completed with:
|
…#8065) This commit refactors common classes from the server module common package to the common and core library so they can be used across serverless and cloud native implementations without depending on the server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
…#8065) This commit refactors common classes from the server module common package to the common and core library so they can be used across serverless and cloud native implementations without depending on the server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8065-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8eea7b986453271cd227a7b98ee09e70d5e28634
# Push it to GitHub
git push --set-upstream origin backport/backport-8065-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…#8065) This commit refactors common classes from the server module common package to the common and core library so they can be used across serverless and cloud native implementations without depending on the server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
This commit refactors common classes from the server module common package to the common and core library so they can be used across serverless and cloud native implementations without depending on the server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
…#8065) This commit refactors common classes from the server module common package to the common and core library so they can be used across serverless and cloud native implementations without depending on the server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This PR refactors common classes that are decoupled from the server implementation from the
:server
common package to the:libs:opensearch-common
and:libs:opensearch-core
library so they can be used across serverless and cloud native implementations without depending on the monolithic:server
module and all transitive dependencies.dependency of #8035
relates #5910