-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TaskCancellationMonitoringService] Changing version check to 2.9 #8069
[TaskCancellationMonitoringService] Changing version check to 2.9 #8069
Conversation
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
I hope that we can get this one merged soon, since the version check mismatch is causing BwC test failures on I'm wondering if we could establish a process where we have both PRs for a version check change (on I've had a couple of these where I've had a backport PR (that changes a version check to whatever the next 2.x release will be) and associated update in main. I manage to get the backport PR merged, but haven't been able to get the main PR merged until a day later -- after I've annoyed everyone else by breaking their Gradle checks. I would love a technical solution that doesn't rely on good intentions, but asking the human maintainers to merge both PRs in quick succession is the best I've been able to think of. I'm going to copy this comment into a dedicated issue. Maybe someone else has a cleverer solution. |
@dblock @andrross @Bukhtawar Can you please help in merging this? As it is causing problems to others as mentioned by @msfroh. |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8069 +/- ##
============================================
- Coverage 70.98% 70.96% -0.03%
+ Complexity 56691 56652 -39
============================================
Files 4722 4722
Lines 267576 267576
Branches 39213 39213
============================================
- Hits 189950 189876 -74
- Misses 61646 61657 +11
- Partials 15980 16043 +63
|
…ensearch-project#8069) Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
…ensearch-project#8069) Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…ensearch-project#8069) Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Changing version check to 2.9.
Related backport PR - #8046
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.