Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Remote Store] Deletion of Remote Segments and Translog upon Index De… #8073

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Jun 15, 2023

…letion (#7682)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

gbbafna and others added 2 commits June 19, 2023 12:24
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      3 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #8073 (fa1efcc) into 2.x (4a090af) will decrease coverage by 0.07%.
The diff coverage is 59.01%.

@@             Coverage Diff              @@
##                2.x    #8073      +/-   ##
============================================
- Coverage     70.71%   70.64%   -0.07%     
+ Complexity    56848    56830      -18     
============================================
  Files          4703     4703              
  Lines        269056   269098      +42     
  Branches      39770    39772       +2     
============================================
- Hits         190263   190116     -147     
- Misses        62452    62637     +185     
- Partials      16341    16345       +4     
Impacted Files Coverage Δ
...search/index/translog/InternalTranslogManager.java 64.78% <0.00%> (+5.50%) ⬆️
...opensearch/index/translog/NoOpTranslogManager.java 64.51% <0.00%> (-2.16%) ⬇️
...rg/opensearch/index/translog/RemoteFsTranslog.java 73.98% <0.00%> (-1.02%) ⬇️
...n/java/org/opensearch/index/translog/Translog.java 83.08% <0.00%> (+2.89%) ⬆️
...dex/translog/transfer/TranslogTransferManager.java 79.77% <33.33%> (-2.69%) ⬇️
...in/java/org/opensearch/index/shard/IndexShard.java 70.20% <54.54%> (-0.05%) ⬇️
...c/main/java/org/opensearch/index/IndexService.java 74.88% <75.00%> (-0.74%) ⬇️
...earch/index/store/RemoteSegmentStoreDirectory.java 90.69% <80.00%> (-0.81%) ⬇️
...n/java/org/opensearch/search/query/QueryPhase.java 78.14% <88.88%> (-0.67%) ⬇️
...va/org/opensearch/index/store/RemoteDirectory.java 88.88% <100.00%> (+0.88%) ⬆️
... and 1 more

... and 454 files with indirect coverage changes

@sachinpkale sachinpkale merged commit bdf292c into opensearch-project:2.x Jun 19, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
… upon Index De… (opensearch-project#8073)

* [Remote Store] Deletion of Remote Segments and Translog upon Index Deletion (opensearch-project#7682)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

* Translog deletion only for remote txlog enabled indices

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants