-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Segment Store] Add Lucene major version to UploadedSegmentMetadata #8088
[Remote Segment Store] Add Lucene major version to UploadedSegmentMetadata #8088
Conversation
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add unit tests for the new functionality?
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Some integration tests are failing, looking into those |
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
2c1e9c7
to
0e1adb4
Compare
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8088-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 611ecc2ad50c7e1833e7fe8ef2a6cabeb6028c57
# Push it to GitHub
git push --set-upstream origin backport/backport-8088-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…adata (opensearch-project#8088) * Add Lucene version to UploadedSegmentMetadata --------- Signed-off-by: Bhumika Saini <sabhumik@amazon.com> (cherry picked from commit 611ecc2)
…adata (opensearch-project#8088) * Add Lucene version to UploadedSegmentMetadata --------- Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
…adata (opensearch-project#8088) * Add Lucene version to UploadedSegmentMetadata --------- Signed-off-by: Bhumika Saini <sabhumik@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…adata (opensearch-project#8088) * Add Lucene version to UploadedSegmentMetadata --------- Signed-off-by: Bhumika Saini <sabhumik@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
…adata (opensearch-project#8088) * Add Lucene version to UploadedSegmentMetadata --------- Signed-off-by: Bhumika Saini <sabhumik@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This PR associates the Lucene major version with each uploaded segment file metadata entry that is maintained in remote store. As part of the Lucene version compatibility check, this major version information stored in the metadata will be used to skip downloading the segment files unnecessarily if they were written by an incompatible Lucene version.
For the segment files that house the segment data (
.cfe
,.cfs
, etc.), we track the Lucene major version as captured in the respectiveSegmentInfo
instance.For the
segment_N
files that house the information on segments, we track the Lucene major version used for the commit as captured in the respectiveSegmentInfos
instance.For the
_<segmentNumber>_<monotonicallyIncrementingCountOfUpdate>_Lucene<major><minor>_<bugfix>.dvm
,_<segmentNumber>_<monotonicallyIncrementingCountOfUpdate>_Lucene<major><minor>_<bugfix>.dvd
, and_<segmentNumber>_<monotonicallyIncrementingCountOfUpdate>.fnm
files, we track the Lucene major version available in the respective.dvm
/.dvd
file's name.Related Issues
Resolves #7722
Check List
Commit changes are listed out in CHANGELOG.md file (See: Changelog)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.