Consume all params and content on extension Rest Request exception #8096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
sachinpkale
as code owners
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8096 +/- ##
============================================
- Coverage 70.92% 70.77% -0.16%
+ Complexity 56664 56507 -157
============================================
Files 4722 4722
Lines 267604 267606 +2
Branches 39214 39214
============================================
- Hits 189803 189386 -417
- Misses 61826 62219 +393
- Partials 15975 16001 +26
|
owaiskazi19
reviewed
Jun 16, 2023
server/src/main/java/org/opensearch/rest/extensions/RestSendToExtensionAction.java
Show resolved
Hide resolved
owaiskazi19
approved these changes
Jun 19, 2023
ryanbogan
approved these changes
Jun 20, 2023
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 21, 2023
…pensearch-project#8096) Signed-off-by: Daniel Widdis <widdis@gmail.com>
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…pensearch-project#8096) (opensearch-project#8183) (cherry picked from commit 1f6a3bc) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
imRishN
pushed a commit
to imRishN/OpenSearch
that referenced
this pull request
Jun 27, 2023
…pensearch-project#8096) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…pensearch-project#8096) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RestRequestobjects track the parameters and content, indented to provide users with more helpful error messages for incorrect API syntax.When a Rest Request forwarded to an Extension fails, the
onResponse()handler method never executes, and these "helpful" error messages end up giving the wrong reason for failure, hiding the actual exceptions.This PR consumes all params and content to prevent this confusion, allowing the actual exception (often a timeout) to be sent to the user.
Related Issues
Resolves opensearch-project/opensearch-sdk-java#587
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.