Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually backport #8107 bump guava to 32.0.1-jre #8114

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

stephen-crawford
Copy link
Contributor

Description

Manually backports #8107 to 2.x

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@stephen-crawford
Copy link
Contributor Author

stephen-crawford commented Jun 16, 2023

I think these may be flaky tests?

Screenshot 2023-06-16 at 3 41 47 PM

I have seen the SegRep tests are flaky not sure about the others.

@kartg
Copy link
Member

kartg commented Jun 16, 2023

Tests with failures:
 - org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness
 - org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
 - org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
 - org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
 - org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPressureServiceStats

All flaky tests (in order):

Refiring gradle check. @scrawfor99 could you also create a manual backport to 1.x so we can patch vulnerabilities for our upcoming 1.3.11 release ?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPressureServiceStats

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #8114 (bb19fdc) into 2.x (59a62e7) will decrease coverage by 0.03%.
The diff coverage is 84.61%.

@@             Coverage Diff              @@
##                2.x    #8114      +/-   ##
============================================
- Coverage     70.63%   70.60%   -0.03%     
- Complexity    56771    56805      +34     
============================================
  Files          4703     4703              
  Lines        269046   269056      +10     
  Branches      39768    39770       +2     
============================================
- Hits         190048   189979      -69     
- Misses        62694    62778      +84     
+ Partials      16304    16299       -5     
Impacted Files Coverage Δ
.../org/opensearch/common/settings/SecureSetting.java 74.62% <84.61%> (+9.71%) ⬆️

... and 463 files with indirect coverage changes

@kartg kartg merged commit 4a090af into opensearch-project:2.x Jun 16, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…pensearch-project#8114)

* Backport guava

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* fix exclusions

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

---------

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants