Enable Point based optimization for custom comparators

[gashutos]

As a part of #6321 and #6424 , we enabled Lucene's numeric sort optimization which are based on BKD point values skipping logic.
We can enable this for our custom comparator as well. Which were disabled while upgrading to Lucene 9.1.0 in this PR 2487.

There is no harm adding this back, queries like below in nyc_taxis are showing 15x improvement on scaled_float numeric types. total_amount is scaled_float.

GET nyc_taxis/_search?size=1000
{
  "sort": [
    {
      "total_amount": {
        "order": "asc"
      }
    }
  ]
}

#8167 will be resolved with this.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/17994/
• CommitID: 5c6a85d
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/17993/
• CommitID: 0ecb840
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[reta]

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE x

* **URL:** https://build.ci.opensearch.org/job/gradle-check/17993/

* **CommitID:** [0ecb840](https://github.com/opensearch-project/OpenSearch/commit/0ecb84005f2cec2fdff4475482579a1bd317c1bf)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

org.opensearch.search.sort.FieldSortIT failures are legit

[gashutos]

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE x

* **URL:** https://build.ci.opensearch.org/job/gradle-check/17993/

* **CommitID:** [0ecb840](https://github.com/opensearch-project/OpenSearch/commit/0ecb84005f2cec2fdff4475482579a1bd317c1bf)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

org.opensearch.search.sort.FieldSortIT failures are legit

Yeah, looking at those.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.snapshots.RestoreSnapshotIT.testRestoreInSameRemoteStoreEnabledIndex
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

• URL: https://build.ci.opensearch.org/job/gradle-check/18550/
• CommitID: e6f7455
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[gashutos]

@reta hardly people have context here on point based optimizations....
Lets merge it ?
I dont think we will be breaking anything with this.

[reta]

@reta hardly people have context here on point based optimizations....

Will do, but you've got new comment, needs to be resolved (merge is blocked)

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18584/
• CommitID: 7217272
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[reta]

@gashutos sorry but needs rebase (to fix the Gradle check)

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

• URL: https://build.ci.opensearch.org/job/gradle-check/18659/
• CommitID: 9c8a4ab
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.snapshots.RestoreSnapshotIT.testRestoreInSameRemoteStoreEnabledIndex
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation

• URL: https://build.ci.opensearch.org/job/gradle-check/18660/
• CommitID: 9c8a4ab
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[gashutos]

@gashutos sorry but needs rebase (to fix the Gradle check)

Done :)

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8168-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 87a833fbedfbcf9029d5e14e0597f8c5e8968086
# Push it to GitHub
git push --set-upstream origin backport/backport-8168-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8168-to-2.x.

[reta]

@gashutos sadly backport to 2.x needs manual work, could you take care of it please?