-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Pass localNode info to all plugins on node start #8192
Merged
reta
merged 2 commits into
opensearch-project:2.x
from
DarshitChanpura:backport/backport-7919-to-2.x
Jun 21, 2023
Merged
[Backport 2.x] Pass localNode info to all plugins on node start #8192
reta
merged 2 commits into
opensearch-project:2.x
from
DarshitChanpura:backport/backport-7919-to-2.x
Jun 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch-project#7919) * Updates Node start to now pass localNode info so that it is available directly to a plugin instead of hacky implementation Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Adds this PR to changelog Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Makes onNodeStarted call plugin agnostic Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Marking onNodeStarted() as deprecated Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Adds a test to verify the behaviour of new signature of onNodeStarted Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Updates test to also check for nodeId Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Adds instructions to use the overloaded implementation of onNodeStarted and adds a test to check that current plugins are not affect with this implementation Signed-off-by: Darshit Chanpura <dchanp@amazon.com> --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> (cherry picked from commit 40d7583)
404f6f5
to
6deb8c3
Compare
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
6deb8c3
to
a9c9664
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
Jun 21, 2023
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #8192 +/- ##
=========================================
Coverage 70.64% 70.65%
+ Complexity 56851 56849 -2
=========================================
Files 4703 4703
Lines 269104 269106 +2
Branches 39774 39774
=========================================
+ Hits 190118 190131 +13
- Misses 62702 62726 +24
+ Partials 16284 16249 -35
|
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…search-project#8192) * [Enhancement] Pass localNode info to all plugins on node start (opensearch-project#7919) * Updates Node start to now pass localNode info so that it is available directly to a plugin instead of hacky implementation Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Adds this PR to changelog Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Makes onNodeStarted call plugin agnostic Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Marking onNodeStarted() as deprecated Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Adds a test to verify the behaviour of new signature of onNodeStarted Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Updates test to also check for nodeId Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Adds instructions to use the overloaded implementation of onNodeStarted and adds a test to check that current plugins are not affect with this implementation Signed-off-by: Darshit Chanpura <dchanp@amazon.com> --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> (cherry picked from commit 40d7583) * Adds a CHANGELOG entry Signed-off-by: Darshit Chanpura <dchanp@amazon.com> --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually backports #7919 to 2.x
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.