-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] Fixed duplicate extension unique id #8228
[Extensions] Fixed duplicate extension unique id #8228
Conversation
4cc6ede
to
ac39864
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8228 +/- ##
============================================
+ Coverage 70.83% 70.92% +0.08%
- Complexity 56652 56715 +63
============================================
Files 4733 4733
Lines 268125 268127 +2
Branches 39283 39284 +1
============================================
+ Hits 189932 190166 +234
+ Misses 62154 61914 -240
- Partials 16039 16047 +8
|
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as a workaround but I think this can be improved.
server/src/main/java/org/opensearch/transport/TransportService.java
Outdated
Show resolved
Hide resolved
d2e28f0
to
c031968
Compare
c031968
to
1ebc1d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
1ebc1d3
to
f15e242
Compare
Gradle Check (Jenkins) Run Completed with:
|
* Fixes duplicate extension unique id Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Handled different extension unique id Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit f21d73e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fixes duplicate extension unique id * Handled different extension unique id --------- (cherry picked from commit f21d73e) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…8228) (opensearch-project#8240) * Fixes duplicate extension unique id * Handled different extension unique id --------- (cherry picked from commit f21d73e) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…8228) * Fixes duplicate extension unique id Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Handled different extension unique id Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…8228) * Fixes duplicate extension unique id Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Handled different extension unique id Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
…8228) * Fixes duplicate extension unique id Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Handled different extension unique id Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
The header
extension_unique_id
is being set twice, in OpenSearch and here in SDK for the case when extension is getting initialized. This header helps OpenSearch to recognize node as an extension node while doingconnectToExtensionNode
. The issue was mostly with threadContext restoring the header and trying to set it again.Related Issues
Closes opensearch-project/opensearch-sdk-java#771
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.