-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication + Remote Store] Removing exception throw when remote store is used with system indices #8235
[Segment Replication + Remote Store] Removing exception throw when remote store is used with system indices #8235
Conversation
…indices. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
@Rishikesh1159 Would the index setting to disable remote-store on system indices override cluster setting to enable remote-store? |
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8235 +/- ##
============================================
+ Coverage 70.83% 70.85% +0.01%
- Complexity 56652 56698 +46
============================================
Files 4733 4733
Lines 268125 268127 +2
Branches 39283 39284 +1
============================================
+ Hits 189932 189974 +42
- Misses 62154 62168 +14
+ Partials 16039 15985 -54
|
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@rishabh6788 yes, index settings will always override cluster level settings |
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java
Show resolved
Hide resolved
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
…ensearch-project#8243) Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
…mote store is used with system indices (opensearch-project#8235) * Removing throwing of exception when remote store is used with system indices. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Add check of feature flag enabled. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Add unit test to improve code coverage. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Add warning log. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…mote store is used with system indices (opensearch-project#8235) * Removing throwing of exception when remote store is used with system indices. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Add check of feature flag enabled. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Add unit test to improve code coverage. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Add warning log. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
…mote store is used with system indices (opensearch-project#8235) * Removing throwing of exception when remote store is used with system indices. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Add check of feature flag enabled. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Add unit test to improve code coverage. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Add warning log. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This PR Removes exception throw when remote store is used with system indices, which was introduced in PR #8186. Instead when system index is used with remote store we just set remote store to false and use document replication. This is a temporary workaround until issue #8158 is fixed.
Related Issues
Resolves #8162
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.