Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication + Remote Store] Removing exception throw when remote store is used with system indices #8235

Merged

Conversation

Rishikesh1159
Copy link
Member

Description

This PR Removes exception throw when remote store is used with system indices, which was introduced in PR #8186. Instead when system index is used with remote store we just set remote store to false and use document replication. This is a temporary workaround until issue #8158 is fixed.

Related Issues

Resolves #8162

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…indices.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@rishabh6788
Copy link
Contributor

@Rishikesh1159 Would the index setting to disable remote-store on system indices override cluster setting to enable remote-store?

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #8235 (01a6d43) into main (84dffac) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #8235      +/-   ##
============================================
+ Coverage     70.83%   70.85%   +0.01%     
- Complexity    56652    56698      +46     
============================================
  Files          4733     4733              
  Lines        268125   268127       +2     
  Branches      39283    39284       +1     
============================================
+ Hits         189932   189974      +42     
- Misses        62154    62168      +14     
+ Partials      16039    15985      -54     
Impacted Files Coverage Δ
...h/cluster/metadata/MetadataCreateIndexService.java 79.75% <100.00%> (-0.11%) ⬇️

... and 449 files with indirect coverage changes

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@Rishikesh1159
Copy link
Member Author

@Rishikesh1159 Would the index setting to disable remote-store on system indices override cluster setting to enable remote-store?

@rishabh6788 yes, index settings will always override cluster level settings

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testBasicTaskResourceTracking

@mch2 mch2 merged commit 3b04ef4 into opensearch-project:main Jun 23, 2023
Rishikesh1159 added a commit to Rishikesh1159/OpenSearch that referenced this pull request Jun 23, 2023
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
mch2 pushed a commit that referenced this pull request Jun 25, 2023
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
…mote store is used with system indices (opensearch-project#8235)

* Removing throwing of exception when remote store is used with system indices.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add check of feature flag enabled.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add unit test to improve code coverage.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add warning log.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
sudarshan-baliga pushed a commit to Gaurav614/OpenSearch that referenced this pull request Jun 29, 2023
…mote store is used with system indices (opensearch-project#8235)

* Removing throwing of exception when remote store is used with system indices.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add check of feature flag enabled.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add unit test to improve code coverage.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add warning log.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…mote store is used with system indices (opensearch-project#8235)

* Removing throwing of exception when remote store is used with system indices.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add check of feature flag enabled.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add unit test to improve code coverage.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add warning log.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants