Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snapshot Interop] Change Version Checks from 3.0 to 2.9 in Restore S… #8319

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

harishbhakuni
Copy link
Contributor

@harishbhakuni harishbhakuni commented Jun 28, 2023

…napshot Changes.

Description

Changes for Restore Snapshot API for Snapshot Interoperability Feature are merged and backported to 2.x branch. now updating the version checks in main to use 2.9 which were kept as 3.0 before to avoid bwc test failures due to ser/de.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…napshot Changes.

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      1 org.opensearch.snapshots.RestoreSnapshotIT.testRestoreInSameRemoteStoreEnabledIndex
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #8319 (32e76bf) into main (4c02dd1) will decrease coverage by 0.44%.
The diff coverage is 75.88%.

@@             Coverage Diff              @@
##               main    #8319      +/-   ##
============================================
- Coverage     70.90%   70.47%   -0.44%     
+ Complexity    56710    56516     -194     
============================================
  Files          4733     4752      +19     
  Lines        268333   268599     +266     
  Branches      39322    39336      +14     
============================================
- Hits         190254   189282     -972     
- Misses        61996    63265    +1269     
+ Partials      16083    16052      -31     
Impacted Files Coverage Δ
...rg/opensearch/telemetry/tracing/SpanReference.java 0.00% <0.00%> (ø)
...ster/snapshots/restore/RestoreSnapshotRequest.java 72.26% <0.00%> (+2.52%) ⬆️
...org/opensearch/cluster/routing/RecoverySource.java 70.77% <0.00%> (ø)
...pensearch/common/settings/FeatureFlagSettings.java 50.00% <ø> (ø)
.../java/org/opensearch/snapshots/RestoreService.java 54.46% <0.00%> (ø)
...racing/ThreadContextBasedTracerContextStorage.java 16.66% <16.66%> (ø)
.../opensearch/telemetry/tracing/noop/NoopTracer.java 25.00% <25.00%> (ø)
server/src/main/java/org/opensearch/node/Node.java 84.95% <27.27%> (-0.89%) ⬇️
...pensearch/telemetry/tracing/NoopTracerFactory.java 50.00% <50.00%> (ø)
...elemetry/tracing/OTelTracingContextPropagator.java 75.00% <75.00%> (ø)
... and 17 more

... and 519 files with indirect coverage changes

@reta reta merged commit b594f52 into opensearch-project:main Jun 28, 2023
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…napshot Changes. (opensearch-project#8319)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Co-authored-by: Harish Bhakuni <hbhakuni@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…napshot Changes. (opensearch-project#8319)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Co-authored-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants