Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix primary balance flaky test #8366

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Fix primary balance flaky test #8366

merged 1 commit into from
Jun 29, 2023

Conversation

kotwanikunal
Copy link
Member

@kotwanikunal kotwanikunal commented Jun 29, 2023 •
edited
Loading

Description

  • Fix primary balance flaky test
  • Asserts for a window within threshold of -1 and +1 of the average value because of the general variance

Tested with the following seeds from the failure mentions

Related Issues

Resolves #7751

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kotwanikunal kotwanikunal added backport 2.x Backport to 2.x branch skip-changelog labels Jun 29, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal
Copy link
Member Author

Seems related. Taking a look

@kotwanikunal
Fix primary balance flaky test
3a23463 
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #8366 (3a23463) into main (22cb650) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #8366      +/-   ##
============================================
- Coverage     70.96%   70.92%   -0.04%     
+ Complexity    56951    56917      -34     
============================================
  Files          4757     4757              
  Lines        269121   269125       +4     
  Branches      39403    39403              
============================================
- Hits         190975   190883      -92     
- Misses        62048    62144      +96     
  Partials      16098    16098
Impacted Files Coverage Δ
.../opensearch/common/xcontent/cbor/CborXContent.java 84.21% <100.00%> (+0.87%) ⬆️
.../opensearch/common/xcontent/json/JsonXContent.java 100.00% <100.00%> (ø)
...pensearch/common/xcontent/smile/SmileXContent.java 90.00% <100.00%> (+0.52%) ⬆️
.../opensearch/common/xcontent/yaml/YamlXContent.java 88.23% <100.00%> (+0.73%) ⬆️

... and 454 files with indirect coverage changes

dreamer-89
dreamer-89 approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kotwanikunal for fixing this. 👍

@dreamer-89 dreamer-89 merged commit ed3124b into opensearch-project:main Jun 29, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 29, 2023
@github-actions
Fix primary balance flaky test (#8366)
d0a5c12 
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit ed3124b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 29, 2023
Closed
@kotwanikunal kotwanikunal mentioned this pull request Jun 29, 2023
Merged
6 tasks
kotwanikunal added a commit to kotwanikunal/OpenSearch that referenced this pull request Jun 30, 2023
@kotwanikunal
Fix primary balance flaky test (opensearch-project#8366)
1ed7032 
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit ed3124b)
kotwanikunal added a commit that referenced this pull request Jun 30, 2023
@kotwanikunal
[Backport 2.x] Fix primary balance flaky test (#8380)
af90dd8 
* Fix primary balance flaky test (#8366)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit ed3124b)

* Add lower and upper bound support for appropriate variance thresholds (#8372)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit a68733a)
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
@kotwanikunal @baba-devv
Fix primary balance flaky test (opensearch-project#8366)
8204813 
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@kotwanikunal @shiv0408
Fix primary balance flaky test (opensearch-project#8366)
7e75d05 
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamer-89 dreamer-89 dreamer-89 approved these changes

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Flaky test SegmentReplicationAllocationIT.testPerIndexPrimaryAllocation
3 participants
@kotwanikunal @reta @dreamer-89