[Backport 2.x] [Search Pipelines] Add stats for search pipelines #8376

mingshl · 2023-06-30T05:09:42Z

Description

manual back-porting #8053 and resolve conflict

Related Issues

Resolves #6723

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-06-30T05:37:49Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/18793/
CommitID: a74d58d
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-06-30T17:36:50Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/18825/
CommitID: a74d58d
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-06-30T22:34:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/18849/
CommitID: 209a00a
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

mingshl · 2023-06-30T22:58:26Z

Need help in rerunning gradle check

msfroh · 2023-07-02T05:08:07Z

It looks like the Gradle check is failing because of the 1.3.11 release -- the buildBwcLinuxTar target is now building 1.3.12?

msfroh · 2023-07-02T05:10:53Z

Note that to avoid breaking backward compatibility tests on main, we will need to update the version checks on main to also check for versions on or after 2.9.0. Please create the PR for that and link it from this PR. They basically need to go in together (until we come up with a better solution).

See #8070 for discussion.

server/src/main/java/org/opensearch/action/admin/cluster/node/stats/NodeStats.java

mingshl · 2023-07-03T21:37:05Z

Note that to avoid breaking backward compatibility tests on main, we will need to update the version checks on main to also check for versions on or after 2.9.0. Please create the PR for that and link it from this PR. They basically need to go in together (until we come up with a better solution).

See #8070 for discussion.

created #8416 to update the version checks on main

@lukas-vlcek

…#8053) * [Search Pipelines] Add stats for search pipelines This adds statistics on executions and time spent on search pipeline operations, similar to the stats that are available for ingest pipelines. Signed-off-by: Michael Froh <froh@amazon.com> * Compare parsed JSON structure, not exact JSON string As @lukas-vlcek pointed out, asserting equality with an exact JSON string is sensitive to formatting, which makes the test brittle. Instead, we can parse the expected JSON and compare as Maps. Signed-off-by: Michael Froh <froh@amazon.com> * Refactor to common stats/metrics classes Search pipelines and ingest pipelines had identical functionality for tracking metrics around operations and converting those to immutable "stats" objects. That approach isn't even really specific to pipelines, but can be used to track metrics on any repeated operation, so I moved that common logic to the common.metrics package. Signed-off-by: Michael Froh <froh@amazon.com> * Split pipeline metrics tracking into its own class Thanks @saratvemulapalli for the suggestion! This lets the Pipeline class focus on transforming requests / responses, while the subclass focuses on tracking and managing metrics. Signed-off-by: Michael Froh <froh@amazon.com> --------- Signed-off-by: Michael Froh <froh@amazon.com> (cherry picked from commit 46c9a21)

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

github-actions · 2023-07-05T17:03:37Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      2 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessAfterFailureInFirstAttemptAfterSnapshotAndMetadataUpload

URL: https://build.ci.opensearch.org/job/gradle-check/19156/
CommitID: 0d648c8
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-07-05T17:05:59Z

Codecov Report

Merging #8376 (7a40bdc) into 2.x (9b9718f) will increase coverage by 0.04%.
The diff coverage is 87.93%.

@@             Coverage Diff              @@
##                2.x    #8376      +/-   ##
============================================
+ Coverage     70.47%   70.52%   +0.04%     
- Complexity    56953    57039      +86     
============================================
  Files          4737     4740       +3     
  Lines        270103   270416     +313     
  Branches      39905    39940      +35     
============================================
+ Hits         190345   190699     +354     
+ Misses        63404    63348      -56     
- Partials      16354    16369      +15

Impacted Files	Coverage Δ
...min/cluster/stats/TransportClusterStatsAction.java	`70.83% <ø> (ø)`
...src/main/java/org/opensearch/node/NodeService.java	`73.49% <0.00%> (-0.90%)`	⬇️
...rch/action/admin/cluster/node/stats/NodeStats.java	`47.66% <33.33%> (-0.71%)`	⬇️
.../action/admin/cluster/stats/ClusterStatsNodes.java	`55.00% <55.55%> (ø)`
.../org/opensearch/common/metrics/OperationStats.java	`78.78% <78.78%> (ø)`
.../java/org/opensearch/search/pipeline/Pipeline.java	`87.83% <85.96%> (-1.82%)`	⬇️
...pensearch/search/pipeline/SearchPipelineStats.java	`89.44% <89.44%> (ø)`
...pensearch/search/pipeline/PipelineWithMetrics.java	`90.90% <90.90%> (ø)`
...main/java/org/opensearch/ingest/IngestService.java	`83.37% <93.75%> (ø)`
...on/admin/cluster/node/stats/NodesStatsRequest.java	`69.30% <100.00%> (+0.30%)`	⬆️
... and 8 more

... and 468 files with indirect coverage changes

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

github-actions · 2023-07-05T21:41:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.testWriteRead
      1 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.testSnapshotWithLargeSegmentFiles
      1 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.testMultipleSnapshotAndRollback
      1 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.testList
      1 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.testIndicesDeletedFromRepository
      1 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.testDeleteBlobs
      1 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.classMethod
      1 org.opensearch.cluster.ClusterHealthIT.testHealthOnClusterManagerFailover

URL: https://build.ci.opensearch.org/job/gradle-check/19184/
CommitID: 7a40bdc
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

mingshl · 2023-07-05T22:30:35Z

Thank you @tlfeng !

mingshl force-pushed the backport/backport-8053-to-2.x branch from a74d58d to 209a00a Compare June 30, 2023 22:11

msfroh requested changes Jul 2, 2023

View reviewed changes

server/src/main/java/org/opensearch/action/admin/cluster/node/stats/NodeStats.java Outdated Show resolved Hide resolved

server/src/main/java/org/opensearch/action/admin/cluster/node/stats/NodeStats.java Outdated Show resolved Hide resolved

mingshl added the v2.9.0 'Issues and PRs related to version v2.9.0' label Jul 3, 2023

noCharger added the Priority-High label Jul 3, 2023

noCharger assigned mingshl Jul 3, 2023

mingshl mentioned this pull request Jul 3, 2023

[Search Pipelines] Changing Version Check to 2.9 #8416

Merged

6 tasks

msfroh and others added 2 commits July 5, 2023 09:22

resolve conflict

0d648c8

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

mingshl force-pushed the backport/backport-8053-to-2.x branch from 209a00a to 0d648c8 Compare July 5, 2023 16:23

remove comments

7a40bdc

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

tlfeng approved these changes Jul 5, 2023

View reviewed changes

tlfeng merged commit d150117 into opensearch-project:2.x Jul 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 2.x] [Search Pipelines] Add stats for search pipelines #8376

[Backport 2.x] [Search Pipelines] Add stats for search pipelines #8376

mingshl commented Jun 30, 2023

github-actions bot commented Jun 30, 2023

github-actions bot commented Jun 30, 2023

github-actions bot commented Jun 30, 2023

mingshl commented Jun 30, 2023

msfroh commented Jul 2, 2023

msfroh commented Jul 2, 2023

mingshl commented Jul 3, 2023 •

edited

Loading

github-actions bot commented Jul 5, 2023

codecov bot commented Jul 5, 2023 •

edited

Loading

github-actions bot commented Jul 5, 2023

mingshl commented Jul 5, 2023

[Backport 2.x] [Search Pipelines] Add stats for search pipelines #8376

[Backport 2.x] [Search Pipelines] Add stats for search pipelines #8376

Conversation

mingshl commented Jun 30, 2023

Description

Related Issues

Check List

github-actions bot commented Jun 30, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jun 30, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jun 30, 2023

Gradle Check (Jenkins) Run Completed with:

mingshl commented Jun 30, 2023

msfroh commented Jul 2, 2023

msfroh commented Jul 2, 2023

mingshl commented Jul 3, 2023 • edited Loading

github-actions bot commented Jul 5, 2023

Gradle Check (Jenkins) Run Completed with:

codecov bot commented Jul 5, 2023 • edited Loading

Codecov Report

github-actions bot commented Jul 5, 2023

Gradle Check (Jenkins) Run Completed with:

mingshl commented Jul 5, 2023

mingshl commented Jul 3, 2023 •

edited

Loading

codecov bot commented Jul 5, 2023 •

edited

Loading