-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid search_after short cutting in case of missing is specified #8391
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8391 +/- ##
============================================
- Coverage 70.95% 70.92% -0.04%
+ Complexity 56943 56937 -6
============================================
Files 4757 4757
Lines 269125 269125
Branches 39403 39403
============================================
- Hits 190955 190872 -83
- Misses 62079 62186 +107
+ Partials 16091 16067 -24
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: gashutos <gashutos@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: gashutos <gashutos@amazon.com> (cherry picked from commit 240193a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8391-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 240193a8b129aaffffb39a57403264b8c4893efb
# Push it to GitHub
git push --set-upstream origin backport/backport-8391-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…nsearch-project#8391) Signed-off-by: gashutos <gashutos@amazon.com>
…) (#8432) Signed-off-by: gashutos <gashutos@amazon.com>
…nsearch-project#8391) Signed-off-by: gashutos <gashutos@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
…nsearch-project#8391) Signed-off-by: gashutos <gashutos@amazon.com>
…nsearch-project#8391) Signed-off-by: gashutos <gashutos@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Fix for #8212.
If
missing
is specified insort
queries like below, it should result documents with null values as well in last. With #7453 optimizations of min/max values short cutting, this is breaking beucase if shard/segment has its min/max values out of search_after range but can still have missing values those are qualified for the output result.Related Issues
Resolves #8212
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.