-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds log4j configuration for telemetry-otel plugin #8393
Adds log4j configuration for telemetry-otel plugin #8393
Conversation
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
@reta @shwetathareja Please take a look. Thanks! |
@Gaganjuneja LGTM but Gradke check is failing (spotless), could you please fix that? |
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8393 +/- ##
============================================
+ Coverage 70.88% 71.01% +0.13%
- Complexity 56926 56976 +50
============================================
Files 4757 4757
Lines 269102 269109 +7
Branches 39396 39397 +1
============================================
+ Hits 190746 191101 +355
+ Misses 62284 61884 -400
- Partials 16072 16124 +52
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8393-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7a5c810a238e0566f0c7bdb6fbc774dafb3674b0
# Push it to GitHub
git push --set-upstream origin backport/backport-8393-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
@Gaganjuneja sadly needs manual backport to |
Yes, will do that. Thanks! |
…t#8393) * Adds log4j configuration for telemetry-otel plugin Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Updates changelog Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes spotless Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
* Adds log4j configuration for telemetry-otel plugin (#8393) * Adds log4j configuration for telemetry-otel plugin Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Updates changelog Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes spotless Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
…t#8393) * Adds log4j configuration for telemetry-otel plugin Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Updates changelog Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes spotless Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
…t#8393) * Adds log4j configuration for telemetry-otel plugin Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Updates changelog Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes spotless Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
…t#8393) * Adds log4j configuration for telemetry-otel plugin Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Updates changelog Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes spotless Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Adds log4j configuration for telemetry-otel LoggingSpanExporter. We will create our on log4j programatic appender later on to avoid the log file generation on case of LoggingSpanExporter is not configured.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.