-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move span operation to Scope from Tracer #8411
Move span operation to Scope from Tracer #8411
Conversation
Signed-off-by: suranjay <surajkumar.tu@gmail.com>
@reta Please have a look of the PR when you get chance |
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: suranjay <surajkumar.tu@gmail.com>
plugins/telemetry-otel/src/main/java/org/opensearch/telemetry/tracing/OTelSpan.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8411 +/- ##
============================================
- Coverage 70.94% 70.87% -0.08%
+ Complexity 57000 56892 -108
============================================
Files 4758 4759 +1
Lines 269186 269189 +3
Branches 39399 39399
============================================
- Hits 190968 190781 -187
- Misses 62148 62322 +174
- Partials 16070 16086 +16
|
libs/telemetry/src/main/java/org/opensearch/telemetry/tracing/Span.java
Outdated
Show resolved
Hide resolved
@suranjay @Gaganjuneja seems like folks you are have conflicting changes #8357 |
Yes, we will rebase the other PR changes which gets merged earlier |
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: suranjay <surajkumar.tu@gmail.com>
e81af5f
to
e5aa24d
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: suranjay <surajkumar.tu@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @suranjay for the refactoring the SpanScope
class.
libs/telemetry/src/main/java/org/opensearch/telemetry/tracing/DefaultTracer.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: suranjay <surajkumar.tu@gmail.com>
Merged changes from @Gaganjuneja commit. @reta Please have a look when you get chance |
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8411-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 39f3c35407d351a0f2ff5e79bb4f6326cc4941f5
# Push it to GitHub
git push --set-upstream origin backport/backport-8411-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
* Move span operation to Scope from Tracer Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Add changelog entry Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Change method to setError Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Removed unused classes Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Fix merge issue Signed-off-by: suranjay <surajkumar.tu@gmail.com> --------- Signed-off-by: suranjay <surajkumar.tu@gmail.com>
) * Move span operation to Scope from Tracer (#8411) * Move span operation to Scope from Tracer Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Add changelog entry Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Change method to setError Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Removed unused classes Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Fix merge issue Signed-off-by: suranjay <surajkumar.tu@gmail.com> --------- Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Empty-Commit Signed-off-by: suranjay <surajkumar.tu@gmail.com> --------- Signed-off-by: suranjay <surajkumar.tu@gmail.com>
* Move span operation to Scope from Tracer Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Add changelog entry Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Change method to setError Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Removed unused classes Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Fix merge issue Signed-off-by: suranjay <surajkumar.tu@gmail.com> --------- Signed-off-by: suranjay <surajkumar.tu@gmail.com>
* Move span operation to Scope from Tracer Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Add changelog entry Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Change method to setError Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Removed unused classes Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Fix merge issue Signed-off-by: suranjay <surajkumar.tu@gmail.com> --------- Signed-off-by: suranjay <surajkumar.tu@gmail.com>
* Move span operation to Scope from Tracer Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Add changelog entry Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Change method to setError Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Removed unused classes Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Fix merge issue Signed-off-by: suranjay <surajkumar.tu@gmail.com> --------- Signed-off-by: suranjay <surajkumar.tu@gmail.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
* Move span operation to Scope from Tracer Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Add changelog entry Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Change method to setError Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Removed unused classes Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Fix merge issue Signed-off-by: suranjay <surajkumar.tu@gmail.com> --------- Signed-off-by: suranjay <surajkumar.tu@gmail.com>
* Move span operation to Scope from Tracer Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Add changelog entry Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Change method to setError Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Removed unused classes Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Fix merge issue Signed-off-by: suranjay <surajkumar.tu@gmail.com> --------- Signed-off-by: suranjay <surajkumar.tu@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This PR makes following changes to Tracing framework
###Related Issues
Resolves #8427
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.