Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tests in restore flow using snapshot interop #8422

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Fix flaky tests in restore flow using snapshot interop #8422

merged 2 commits into from
Jul 4, 2023

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Jul 4, 2023 •
edited
Loading

Description

  • Integ tests in RestoreSnapshotIT that used remote store integration were flaky due to client used from the stopped node.
  • In this fix, we are re-initializing the client after stopping the node.

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Fix flaky tests in restore flow using snapshot interop
8a5f22a 
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Address PR comments
81ca831 
Signed-off-by: Sachin Kale <kalsac@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure

@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #8422 (81ca831) into main (a3b515a) will increase coverage by 0.30%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8422      +/-   ##
============================================
+ Coverage     70.53%   70.84%   +0.30%     
- Complexity    56529    56900     +371     
============================================
  Files          4758     4758              
  Lines        269186   269186              
  Branches      39408    39408              
============================================
+ Hits         189873   190701     +828     
+ Misses        63128    62410     -718     
+ Partials      16185    16075     -110

see 496 files with indirect coverage changes

ashking94
ashking94 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation
      1 org.opensearch.gateway.ReplicaShardAllocatorIT.testPreferCopyWithHighestMatchingOperations

@gbbafna gbbafna merged commit 64c0871 into opensearch-project:main Jul 4, 2023
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Jul 4, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 4, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 4, 2023
@github-actions
Fix flaky tests in restore flow using snapshot interop (#8422)
23fdedf 
Signed-off-by: Sachin Kale <kalsac@amazon.com>
(cherry picked from commit 64c0871)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sachinpkale sachinpkale mentioned this pull request Jul 4, 2023
Closed
gbbafna pushed a commit that referenced this pull request Jul 4, 2023
@opensearch-trigger-bot
Fix flaky tests in restore flow using snapshot interop (#8422) (#8424)
8d78b8c 
(cherry picked from commit 64c0871)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
@sachinpkale
Fix flaky tests in restore flow using snapshot interop (opensearch-pr…
ea7b725 
…oject#8422)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
@sachinpkale @baba-devv
Fix flaky tests in restore flow using snapshot interop (opensearch-pr…
2adb72a 
…oject#8422)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@sachinpkale @shiv0408
Fix flaky tests in restore flow using snapshot interop (opensearch-pr…
8e1c788 
…oject#8422)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@ashking94 ashking94 ashking94 approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sachinpkale @ashking94 @gbbafna