-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle replication cases where the remote store metadata file is not present #8433
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8433 +/- ##
============================================
- Coverage 71.01% 70.86% -0.15%
+ Complexity 57029 56909 -120
============================================
Files 4758 4758
Lines 269251 269188 -63
Branches 39401 39409 +8
============================================
- Hits 191214 190771 -443
- Misses 61958 62289 +331
- Partials 16079 16128 +49
|
Gradle Check (Jenkins) Run Completed with:
|
…present Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ankit Kala <ankikala@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ankit Kala <ankikala@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/indices/replication/RemoteStoreReplicationSource.java
Show resolved
Hide resolved
…present (#8433) * Handle replication cases where the remote store metadata file is not present Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Allow null metadata file only if shard is not started Signed-off-by: Ankit Kala <ankikala@amazon.com> --------- Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> (cherry picked from commit 7e8740f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Not sure how this test passed the checks here - i'd expect not having the segrep flag enabled to fail this test 100% of the time. #8704 should fix this. |
…present (#8433) (#8692) * Handle replication cases where the remote store metadata file is not present * Allow null metadata file only if shard is not started --------- (cherry picked from commit 7e8740f) Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…present (opensearch-project#8433) * Handle replication cases where the remote store metadata file is not present Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Allow null metadata file only if shard is not started Signed-off-by: Ankit Kala <ankikala@amazon.com> --------- Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
…present (opensearch-project#8433) * Handle replication cases where the remote store metadata file is not present Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Allow null metadata file only if shard is not started Signed-off-by: Ankit Kala <ankikala@amazon.com> --------- Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com>
…present (opensearch-project#8433) * Handle replication cases where the remote store metadata file is not present Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Allow null metadata file only if shard is not started Signed-off-by: Ankit Kala <ankikala@amazon.com> --------- Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…present (opensearch-project#8433) * Handle replication cases where the remote store metadata file is not present Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Allow null metadata file only if shard is not started Signed-off-by: Ankit Kala <ankikala@amazon.com> --------- Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Handle the case in segrep with remote where primary hasn't refreshed yet. This is required because we trigger a force sync here
Related Issues
Resolves #8325
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.