Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle replication cases where the remote store metadata file is not present #8433

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

ankitkala
Copy link
Member

Description

Handle the case in segrep with remote where primary hasn't refreshed yet. This is required because we trigger a force sync here

Related Issues

Resolves #8325

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testBasicTaskResourceTracking

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #8433 (69596ea) into main (2f9728e) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head 69596ea differs from pull request most recent head 041e614. Consider uploading reports for the commit 041e614 to get more accurate results

@@             Coverage Diff              @@
##               main    #8433      +/-   ##
============================================
- Coverage     71.01%   70.86%   -0.15%     
+ Complexity    57029    56909     -120     
============================================
  Files          4758     4758              
  Lines        269251   269188      -63     
  Branches      39401    39409       +8     
============================================
- Hits         191214   190771     -443     
- Misses        61958    62289     +331     
- Partials      16079    16128      +49     
Impacted Files Coverage Δ
...ices/replication/RemoteStoreReplicationSource.java 93.93% <100.00%> (+0.39%) ⬆️

... and 494 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Gradle Check (Jenkins) Run Completed with:

ankitkala added 2 commits July 7, 2023 17:06
…present

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ankit Kala <ankikala@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Gradle Check (Jenkins) Run Completed with:

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Ankit Kala <ankikala@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@mch2 mch2 merged commit 7e8740f into opensearch-project:main Jul 14, 2023
@mch2 mch2 added the backport 2.x Backport to 2.x branch label Jul 14, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 14, 2023
…present (#8433)

* Handle replication cases where the remote store metadata file is not present

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Allow null metadata file only if shard is not started

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
(cherry picked from commit 7e8740f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mch2
Copy link
Member

mch2 commented Jul 14, 2023

Not sure how this test passed the checks here - i'd expect not having the segrep flag enabled to fail this test 100% of the time. #8704 should fix this.

dreamer-89 pushed a commit that referenced this pull request Jul 14, 2023
…present (#8433) (#8692)

* Handle replication cases where the remote store metadata file is not present




* Allow null metadata file only if shard is not started



---------



(cherry picked from commit 7e8740f)

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
…present (opensearch-project#8433)

* Handle replication cases where the remote store metadata file is not present

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Allow null metadata file only if shard is not started

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…present (opensearch-project#8433)

* Handle replication cases where the remote store metadata file is not present

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Allow null metadata file only if shard is not started

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…present (opensearch-project#8433)

* Handle replication cases where the remote store metadata file is not present

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Allow null metadata file only if shard is not started

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…present (opensearch-project#8433)

* Handle replication cases where the remote store metadata file is not present

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Allow null metadata file only if shard is not started

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Seeing replica shard failure when running experimental segrep remote integrated index
3 participants