Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmute remote store test testPressureServiceStats #8458

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

kotwanikunal
Copy link
Member

Description

  • Unmutes SegmentReplicationUsingRemoteStoreIT.testPressureServiceStats() as it does not fail with the linked seeds
  • Tested with the following seeds:
- 6FBC0417BD6F56E8 (https://build.ci.opensearch.org/job/gradle-check/15525)
- 9E739B916891FC83 (https://build.ci.opensearch.org/job/gradle-check/18400/) 
- 6D4AC220FB10A7F1 (https://build.ci.opensearch.org/job/gradle-check/15780/)
- 7F31E8DDB5E9A165 (https://build.ci.opensearch.org/job/gradle-check/15533)
- 8D757DA0D0D145D2 (https://build.ci.opensearch.org/job/gradle-check/17783/)
- 73A2F9AEDE71F705 (https://build.ci.opensearch.org/job/gradle-check/17803)
- 7C703462CB16D721 (https://build.ci.opensearch.org/job/gradle-check/17824)
- 1392808F9FD4A3EF (https://build.ci.opensearch.org/job/gradle-check/17927/)
- F32B62765BE17A94 (https://build.ci.opensearch.org/job/gradle-check/17882)
- C2A08952AF8618F3 (https://build.ci.opensearch.org/job/gradle-check/17943)
- 50087ABEA0EF2155 (https://build.ci.opensearch.org/job/gradle-check/17945)
- F63042758D4497E1 (https://build.ci.opensearch.org/job/gradle-check/18130)
- 86C25DA47FA4C58B (https://build.ci.opensearch.org/job/gradle-check/18292)
- F3475375E31DC89D (https://build.ci.opensearch.org/job/gradle-check/18214)
- 9E739B916891FC83 (https://build.ci.opensearch.org/job/gradle-check/18400) 
  • Fixes to remote store and segrep integration seems to have fixed the test

Related Issues

Resolves #7592

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kotwanikunal for the effort on this issue.

In order to evaluate current state on flakyness, I would suggest to run this test locally without seed for 100+ iterations.

@kotwanikunal
Copy link
Member Author

Thanks @kotwanikunal for the effort on this issue.

In order to evaluate current state on flakyness, I would suggest to run this test locally without seed for 100+ iterations.

kkotwani@.. OpenSearch % ./gradlew ':server:internalClusterTest' --tests "org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPressureServiceStats" -Dtests.iters=200

....

> Task :server:internalClusterTest
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/Users/kkotwani/workspace/OSGeneral/OpenSearch/test/framework/build/distributions/framework-3.0.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/Users/kkotwani/.gradle/wrapper/dists/gradle-8.1.1-all/bs1rrjki8hh9bujwbsqnxtuzr/gradle-8.1.1/lib/plugins/gradle-testing-base-8.1.1.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

BUILD SUCCESSFUL in 8m 30s
50 actionable tasks: 5 executed, 45 up-to-date

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #8458 (e12be3c) into main (4657fe7) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8458      +/-   ##
============================================
- Coverage     70.89%   70.85%   -0.05%     
- Complexity    56927    56964      +37     
============================================
  Files          4758     4758              
  Lines        269219   269219              
  Branches      39407    39407              
============================================
- Hits         190876   190760     -116     
- Misses        62268    62389     +121     
+ Partials      16075    16070       -5     

see 472 files with indirect coverage changes

@dreamer-89 dreamer-89 merged commit 8bebf5b into opensearch-project:main Jul 6, 2023
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
@kotwanikunal kotwanikunal deleted the fix-8100 branch July 12, 2023 19:52
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
…#8458)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…#8458)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testPressureServiceStats is flaky
2 participants