-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #7909: Enable Fast Double Parser in Jackson with system property #8467
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #8467 +/- ##
============================================
+ Coverage 70.54% 70.62% +0.07%
- Complexity 57051 57073 +22
============================================
Files 4746 4746
Lines 270451 270463 +12
Branches 39931 39931
============================================
+ Hits 190795 191003 +208
+ Misses 63287 62986 -301
- Partials 16369 16474 +105
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
@backslasht @dblock @reta I've updated the backport PR with an opt in system property for double serialization flag as per the discussion on original PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @mgodwan
libs/x-content/src/main/java/org/opensearch/common/xcontent/cbor/CborXContent.java
Show resolved
Hide resolved
libs/x-content/src/main/java/org/opensearch/common/xcontent/cbor/CborXContent.java
Outdated
Show resolved
Hide resolved
@mgodwan please create the documentation issue for 2.9 release (https://github.com/opensearch-project/documentation-website/), we need to document the new property for others to use. Example opensearch-project/documentation-website#4089 |
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Opened the documentation issue: opensearch-project/documentation-website#4513 |
Gradle Check (Jenkins) Run Completed with:
|
Backport of #7909