Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #7909: Enable Fast Double Parser in Jackson with system property #8467

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

mgodwan
Copy link
Member

@mgodwan mgodwan commented Jul 6, 2023

Backport of #7909

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #8467 (f5b2b52) into 2.x (d044f9b) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #8467      +/-   ##
============================================
+ Coverage     70.54%   70.62%   +0.07%     
- Complexity    57051    57073      +22     
============================================
  Files          4746     4746              
  Lines        270451   270463      +12     
  Branches      39931    39931              
============================================
+ Hits         190795   191003     +208     
+ Misses        63287    62986     -301     
- Partials      16369    16474     +105     
Impacted Files Coverage Δ
.../opensearch/common/xcontent/cbor/CborXContent.java 85.71% <100.00%> (+2.38%) ⬆️
.../opensearch/common/xcontent/json/JsonXContent.java 100.00% <100.00%> (ø)
...pensearch/common/xcontent/smile/SmileXContent.java 90.90% <100.00%> (+1.43%) ⬆️
.../opensearch/common/xcontent/yaml/YamlXContent.java 89.47% <100.00%> (+1.97%) ⬆️

... and 498 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

@mgodwan
Copy link
Member Author

mgodwan commented Jul 6, 2023

@backslasht @dblock @reta I've updated the backport PR with an opt in system property for double serialization flag as per the discussion on original PR

Copy link
Contributor

@backslasht backslasht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mgodwan

@reta
Copy link
Collaborator

reta commented Jul 6, 2023

@mgodwan please create the documentation issue for 2.9 release (https://github.com/opensearch-project/documentation-website/), we need to document the new property for others to use. Example opensearch-project/documentation-website#4089

mgodwan and others added 3 commits July 6, 2023 21:49
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

@mgodwan
Copy link
Member Author

mgodwan commented Jul 6, 2023

Opened the documentation issue: opensearch-project/documentation-website#4513

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocationWithSegRepFailure
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants