-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing search shard failure logging to trace from debug #8470
Changing search shard failure logging to trace from debug #8470
Conversation
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
@jainankitk @shwetathareja Can you take a quick look at this change? |
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/action/search/AbstractSearchAsyncAction.java
Show resolved
Hide resolved
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/action/search/AbstractSearchAsyncAction.java
Show resolved
Hide resolved
@shwetathareja I would need help in merging this. |
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
@andrross @dblock @Bukhtawar Can anyone of you help me getting this reviewed or merged if looks okay? |
@sgup432 There are a few unresolved comments. You have responded but please resolve these conversations (either you or the commenter) before I can merge it in. |
Gradle Check (Jenkins) Run Completed with:
|
@kotwanikunal I have resolved the comments. |
* Changing shard failure logging to trace from debug * Moving the exception to trace logs Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> (cherry picked from commit e8f1c30) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) * Changing shard failure logging to trace from debug * Moving the exception to trace logs Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com --------- (cherry picked from commit e8f1c30) Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…-project#8470) * Changing shard failure logging to trace from debug * Moving the exception to trace logs Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
…-project#8470) * Changing shard failure logging to trace from debug * Moving the exception to trace logs Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
…-project#8470) * Changing shard failure logging to trace from debug * Moving the exception to trace logs Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…-project#8470) * Changing shard failure logging to trace from debug * Moving the exception to trace logs Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Currently we have logging level set to DEBUG for
org.opensearch.action
package likeEvery time there is a failure on shard for example due to search queue size filling up, we log shard failure message along with complete exception stacktrace which is known to be expensive. So in scenarios, where there are a lot of queue rejections happening, this logging further degrades the cluster performance in terms of CPU, Heap, Disk I/O as mentioned here.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#7830
Alternate approach
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.